Commit aa8b8f9f authored Jun 14, 2019 by Nick Crews Committed by Enric Balletbo i Serra Jun 18, 2019

platform/chrome: wilco_ec: Fix unreleased lock in event_read()



When copying an event to userspace failed, the event queue
lock was never released. This fixes that.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nick Crews <ncrews@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

parent 35b52b33

drivers/platform/chrome/wilco_ec/event.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -342,7 +342,7 @@ static ssize_t event_read(struct file filp, char __user buf, size_t count,
		struct ec_event_entry, list);
		n_bytes_written = entry->size;
		if (copy_to_user(buf, &entry->event, n_bytes_written))
		return -EFAULT;
		n_bytes_written = -EFAULT;
		list_del(&entry->list);
		kfree(entry);
		dev_data->num_events--;

Admin message