Commit aa42d7c6 authored Sep 28, 2008 by Arjan van de Ven Committed by Jesse Barnes Oct 20, 2008

PCI: introduce an pci_ioremap(pdev, barnr) function

A common thing in many PCI drivers is to ioremap() an entire bar. This
is a slightly fragile thing right now, needing both an address and a
size, and many driver writers do.. various things there.

This patch introduces an pci_ioremap() function taking just a PCI device
struct and the bar number as arguments, and figures this all out itself,
in one place. In addition, we can add various sanity checks to this
function (the patch already checks to make sure that the bar in question
really is a MEM bar; few to no drivers do that sort of thing).

Hopefully with this type of API we get less chance of mistakes in
drivers with ioremap() operations.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent e9f82cb7

include/linux/pci.h

+13 −0

Original line number	Diff line number	Diff line
		@@ -1119,5 +1119,18 @@ static inline void pci_mmcfg_early_init(void) { }
		static inline void pci_mmcfg_late_init(void) { }
		#endif

		static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
		{
		/*
		* Make sure the BAR is actually a memory resource, not an IO resource
		*/
		if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM)) {
		WARN_ON(1);
		return NULL;
		}
		return ioremap_nocache(pci_resource_start(pdev, bar),
		pci_resource_len(pdev, bar));
		}

		#endif /* __KERNEL__ */
		#endif /* LINUX_PCI_H */

Admin message