Commit aa1e816f authored Apr 18, 2006 by Jesper Juhl Committed by Linus Torvalds Apr 19, 2006

[PATCH] Fix potential NULL pointer deref in gen_init_cpio



Fix potential NULL pointer deref in gen_init_cpio.c spotted by coverity
checker.  This fixes coverity bug #86

Without this patch we risk dereferencing a NULL `type' in the
"if ('\n' == *type) {" line.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 9dfb563b

usr/gen_init_cpio.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -471,6 +471,7 @@ int main (int argc, char *argv[])
		"ERROR: incorrect format, could not locate file type line %d: '%s'\n",
		line_nr, line);
		ec = -1;
		break;
		}

		if ('\n' == *type) {
		@@ -506,6 +507,7 @@ int main (int argc, char *argv[])
		line_nr, line);
		}
		}
		if (ec == 0)
		cpio_trailer();

		exit(ec);

Admin message