Commit aa18efb2 authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

tracing: use recursive counter over irq level 



Althought using the irq level (hardirq_count, softirq_count and in_nmi)
was nice to detect bad recursion right away, but since the counters are
not atomically updated with respect to the interrupts, the function tracer
might trigger the test from an interrupt handler before the hardirq_count
is updated. This will trigger a false warning.

This patch converts the recursive detection to a simple counter.
If the depth is greater than 16 then the recursive detection will trigger.
16 is more than enough for any nested interrupts.

[ Impact: fix false positive trace recursion detection ]

Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent e395898e

kernel/trace/ring_buffer.c

+16 −29
Original line number Diff line number Diff line
@@ -1481,25 +1481,21 @@ rb_reserve_next_event(struct ring_buffer_per_cpu *cpu_buffer, 
	return event;

}



static int trace_irq_level(void)

{

	return (hardirq_count() >> HARDIRQ_SHIFT) +

		(softirq_count() >> + SOFTIRQ_SHIFT) +

		!!in_nmi();

}

#define TRACE_RECURSIVE_DEPTH 16



static int trace_recursive_lock(void)

{

	int level;

	current->trace_recursion++;



	level = trace_irq_level();

	if (likely(current->trace_recursion < TRACE_RECURSIVE_DEPTH))

		return 0;



	if (unlikely(current->trace_recursion & (1 << level))) {

	/* Disable all tracing before we do anything else */

	tracing_off_permanent();



		printk_once(KERN_WARNING "Tracing recursion: "

	printk_once(KERN_WARNING "Tracing recursion: depth[%d]:"

		    "HC[%lu]:SC[%lu]:NMI[%lu]\n",

		    current->trace_recursion,

		    hardirq_count() >> HARDIRQ_SHIFT,

		    softirq_count() >> SOFTIRQ_SHIFT,

		    in_nmi());
@@ -1508,20 +1504,11 @@ static int trace_recursive_lock(void) 
	return -1;

}



	current->trace_recursion |= 1 << level;



	return 0;

}



static void trace_recursive_unlock(void)

{

	int level;



	level = trace_irq_level();



	WARN_ON_ONCE(!current->trace_recursion & (1 << level));

	WARN_ON_ONCE(!current->trace_recursion);



	current->trace_recursion &= ~(1 << level);

	current->trace_recursion--;

}



static DEFINE_PER_CPU(int, rb_need_resched);

CRA Git | Maintained and supported by SUSTech CRA and CCSE