Commit aa0a34be authored by Haiyang Zhang's avatar Haiyang Zhang Committed by David S. Miller
Browse files

hv_netvsc: Implement partial copy into send buffer 



If remaining space in a send buffer slot is too small for the whole message,
we only copy the RNDIS header and PPI data into send buffer, so we can batch
one more packet each time. It reduces the vmbus per-message overhead.

Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6e8a9d91

drivers/net/hyperv/hyperv_net.h

+5 −0
Original line number Original line Diff line number Diff line
@@ -132,6 +132,8 @@ struct hv_netvsc_packet { 




	bool is_data_pkt;

	bool is_data_pkt;

	bool xmit_more; /* from skb */

	bool xmit_more; /* from skb */

	bool cp_partial; /* partial copy into send buffer */



	u16 vlan_tci;

	u16 vlan_tci;





	u16 q_idx;

	u16 q_idx;
@@ -146,6 +148,9 @@ struct hv_netvsc_packet { 
	/* This points to the memory after page_buf */

	/* This points to the memory after page_buf */

	struct rndis_message *rndis_msg;

	struct rndis_message *rndis_msg;





	u32 rmsg_size; /* RNDIS header and PPI size */

	u32 rmsg_pgcnt; /* page count of RNDIS header and PPI */



	u32 total_data_buflen;

	u32 total_data_buflen;

	/* Points to the send/receive buffer where the ethernet frame is */

	/* Points to the send/receive buffer where the ethernet frame is */

	void *data;

	void *data;

drivers/net/hyperv/netvsc.c

+34 −16
Original line number Original line Diff line number Diff line
@@ -703,15 +703,18 @@ static u32 netvsc_copy_to_send_buf(struct netvsc_device *net_device, 
	u32 msg_size = 0;

	u32 msg_size = 0;

	u32 padding = 0;

	u32 padding = 0;

	u32 remain = packet->total_data_buflen % net_device->pkt_align;

	u32 remain = packet->total_data_buflen % net_device->pkt_align;

	u32 page_count = packet->cp_partial ? packet->rmsg_pgcnt :

		packet->page_buf_cnt;





	/* Add padding */

	/* Add padding */

	if (packet->is_data_pkt && packet->xmit_more && remain) {

	if (packet->is_data_pkt && packet->xmit_more && remain &&

	    !packet->cp_partial) {

		padding = net_device->pkt_align - remain;

		padding = net_device->pkt_align - remain;

		packet->rndis_msg->msg_len += padding;

		packet->rndis_msg->msg_len += padding;

		packet->total_data_buflen += padding;

		packet->total_data_buflen += padding;

	}

	}





	for (i = 0; i < packet->page_buf_cnt; i++) {

	for (i = 0; i < page_count; i++) {

		char *src = phys_to_virt(packet->page_buf[i].pfn << PAGE_SHIFT);

		char *src = phys_to_virt(packet->page_buf[i].pfn << PAGE_SHIFT);

		u32 offset = packet->page_buf[i].offset;

		u32 offset = packet->page_buf[i].offset;

		u32 len = packet->page_buf[i].len;

		u32 len = packet->page_buf[i].len;
@@ -739,6 +742,7 @@ static inline int netvsc_send_pkt( 
	struct net_device *ndev = net_device->ndev;

	struct net_device *ndev = net_device->ndev;

	u64 req_id;

	u64 req_id;

	int ret;

	int ret;

	struct hv_page_buffer *pgbuf;





	nvmsg.hdr.msg_type = NVSP_MSG1_TYPE_SEND_RNDIS_PKT;

	nvmsg.hdr.msg_type = NVSP_MSG1_TYPE_SEND_RNDIS_PKT;

	if (packet->is_data_pkt) {

	if (packet->is_data_pkt) {
@@ -766,8 +770,10 @@ static inline int netvsc_send_pkt( 
		return -ENODEV;

		return -ENODEV;





	if (packet->page_buf_cnt) {

	if (packet->page_buf_cnt) {

		pgbuf = packet->cp_partial ? packet->page_buf +

			packet->rmsg_pgcnt : packet->page_buf;

		ret = vmbus_sendpacket_pagebuffer(out_channel,

		ret = vmbus_sendpacket_pagebuffer(out_channel,

						  packet->page_buf,

						  pgbuf,

						  packet->page_buf_cnt,

						  packet->page_buf_cnt,

						  &nvmsg,

						  &nvmsg,

						  sizeof(struct nvsp_message),

						  sizeof(struct nvsp_message),
@@ -824,6 +830,7 @@ int netvsc_send(struct hv_device *device, 
	unsigned long flag;

	unsigned long flag;

	struct multi_send_data *msdp;

	struct multi_send_data *msdp;

	struct hv_netvsc_packet *msd_send = NULL, *cur_send = NULL;

	struct hv_netvsc_packet *msd_send = NULL, *cur_send = NULL;

	bool try_batch;





	net_device = get_outbound_net_device(device);

	net_device = get_outbound_net_device(device);

	if (!net_device)

	if (!net_device)
@@ -837,6 +844,7 @@ int netvsc_send(struct hv_device *device, 
	}

	}

	packet->channel = out_channel;

	packet->channel = out_channel;

	packet->send_buf_index = NETVSC_INVALID_INDEX;

	packet->send_buf_index = NETVSC_INVALID_INDEX;

	packet->cp_partial = false;





	msdp = &net_device->msd[q_idx];

	msdp = &net_device->msd[q_idx];
@@ -845,11 +853,17 @@ int netvsc_send(struct hv_device *device, 
	if (msdp->pkt)

	if (msdp->pkt)

		msd_len = msdp->pkt->total_data_buflen;

		msd_len = msdp->pkt->total_data_buflen;





	if (packet->is_data_pkt && msd_len > 0 &&

	try_batch = packet->is_data_pkt && msd_len > 0 && msdp->count <

	    msdp->count < net_device->max_pkt &&

		    net_device->max_pkt;

	    msd_len + pktlen + net_device->pkt_align <



	if (try_batch && msd_len + pktlen + net_device->pkt_align <

	    net_device->send_section_size) {

		section_index = msdp->pkt->send_buf_index;



	} else if (try_batch && msd_len + packet->rmsg_size <

		   net_device->send_section_size) {

		   net_device->send_section_size) {

		section_index = msdp->pkt->send_buf_index;

		section_index = msdp->pkt->send_buf_index;

		packet->cp_partial = true;





	} else if (packet->is_data_pkt && pktlen + net_device->pkt_align <

	} else if (packet->is_data_pkt && pktlen + net_device->pkt_align <

		   net_device->send_section_size) {

		   net_device->send_section_size) {
@@ -866,22 +880,26 @@ int netvsc_send(struct hv_device *device, 
		netvsc_copy_to_send_buf(net_device,

		netvsc_copy_to_send_buf(net_device,

					section_index, msd_len,

					section_index, msd_len,

					packet);

					packet);

		if (!packet->part_of_skb) {

			skb = (struct sk_buff *)

				(unsigned long)

				packet->send_completion_tid;





			packet->send_completion_tid = 0;

		packet->send_buf_index = section_index;

		}





		if (packet->cp_partial) {

			packet->page_buf_cnt -= packet->rmsg_pgcnt;

			packet->total_data_buflen = msd_len + packet->rmsg_size;

		} else {

			packet->page_buf_cnt = 0;

			packet->page_buf_cnt = 0;

		packet->send_buf_index = section_index;

			packet->total_data_buflen += msd_len;

			packet->total_data_buflen += msd_len;

			if (!packet->part_of_skb) {

				skb = (struct sk_buff *)(unsigned long)packet->

				       send_completion_tid;

				packet->send_completion_tid = 0;

			}

		}





		if (msdp->pkt)

		if (msdp->pkt)

			netvsc_xmit_completion(msdp->pkt);

			netvsc_xmit_completion(msdp->pkt);





		if (packet->xmit_more) {

		if (packet->xmit_more && !packet->cp_partial) {

			msdp->pkt = packet;

			msdp->pkt = packet;

			msdp->count++;

			msdp->count++;

		} else {

		} else {

drivers/net/hyperv/netvsc_drv.c

+7 −3
Original line number Original line Diff line number Diff line
@@ -277,15 +277,16 @@ static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, 
}

}





static u32 init_page_array(void *hdr, u32 len, struct sk_buff *skb,

static u32 init_page_array(void *hdr, u32 len, struct sk_buff *skb,

			   struct hv_page_buffer *pb)

			   struct hv_netvsc_packet *packet)

{

{

	struct hv_page_buffer *pb = packet->page_buf;

	u32 slots_used = 0;

	u32 slots_used = 0;

	char *data = skb->data;

	char *data = skb->data;

	int frags = skb_shinfo(skb)->nr_frags;

	int frags = skb_shinfo(skb)->nr_frags;

	int i;

	int i;





	/* The packet is laid out thus:

	/* The packet is laid out thus:

	 * 1. hdr

	 * 1. hdr: RNDIS header and PPI

	 * 2. skb linear data

	 * 2. skb linear data

	 * 3. skb fragment data

	 * 3. skb fragment data

	 */

	 */
@@ -294,6 +295,9 @@ static u32 init_page_array(void *hdr, u32 len, struct sk_buff *skb, 
					offset_in_page(hdr),

					offset_in_page(hdr),

					len, &pb[slots_used]);

					len, &pb[slots_used]);





	packet->rmsg_size = len;

	packet->rmsg_pgcnt = slots_used;



	slots_used += fill_pg_buf(virt_to_page(data),

	slots_used += fill_pg_buf(virt_to_page(data),

				offset_in_page(data),

				offset_in_page(data),

				skb_headlen(skb), &pb[slots_used]);

				skb_headlen(skb), &pb[slots_used]);
@@ -578,7 +582,7 @@ do_send: 
	rndis_msg->msg_len += rndis_msg_size;

	rndis_msg->msg_len += rndis_msg_size;

	packet->total_data_buflen = rndis_msg->msg_len;

	packet->total_data_buflen = rndis_msg->msg_len;

	packet->page_buf_cnt = init_page_array(rndis_msg, rndis_msg_size,

	packet->page_buf_cnt = init_page_array(rndis_msg, rndis_msg_size,

					skb, &page_buf[0]);

					       skb, packet);





	ret = netvsc_send(net_device_ctx->device_ctx, packet);

	ret = netvsc_send(net_device_ctx->device_ctx, packet);

CRA Git | Maintained and supported by SUSTech CRA and CCSE