Commit aa033810 authored May 20, 2013 by Stephen Boyd Committed by Linus Torvalds May 21, 2013

ARM: smp: Drop RCU_NONIDLE usage in cpu_die()



Before f7b861b7 ("arm: Use generic idle loop") ARM would kill the
CPU within the rcu idle section.  Now that the rcu_idle_enter()/exit()
pair have been pushed lower down in the idle loop this is no longer true
and so using RCU_NONIDLE here is no longer necessary and also harmful
because RCU is not actually idle at this point.

Cc: Russell King <linux@arm.linux.org.uk>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0ddaa974

arch/arm/kernel/smp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -251,7 +251,7 @@ void __ref cpu_die(void)
		* this returns, power and/or clocks can be removed at any point
		* from this CPU and its cache by platform_cpu_kill().
		*/
		RCU_NONIDLE(complete(&cpu_died));
		complete(&cpu_died);

		/*
		* Ensure that the cache lines associated with that completion are

Admin message