Bluetooth: Allow suspend even when preparation has failed (a9ec8423) · Commits · 戴 / test

It is preferable to allow suspend even when Bluetooth has problems preparing for sleep. When Bluetooth fails to finish preparing for suspend, log the error and allow the suspend notifier to continue instead. To also make it clearer why suspend failed, change bt_dev_dbg to bt_dev_err when handling the suspend timeout. Fixes: ("Bluetooth: Handle LE devices during suspend") Reported-by:

Len Brown <len.brown@intel.com> Signed-off-by:

Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Signed-off-by:

Marcel Holtmann <marcel@holtmann.org>

net/bluetooth/hci_core.c

+10 −7

Original line number	Diff line number	Diff line
		@@ -3289,10 +3289,10 @@ static int hci_suspend_wait_event(struct hci_dev *hdev)
		WAKE_COND, SUSPEND_NOTIFIER_TIMEOUT);

		if (ret == 0) {
		bt_dev_dbg(hdev, "Timed out waiting for suspend");
		bt_dev_err(hdev, "Timed out waiting for suspend events");
		for (i = 0; i < __SUSPEND_NUM_TASKS; ++i) {
		if (test_bit(i, hdev->suspend_tasks))
		bt_dev_dbg(hdev, "Bit %d is set", i);
		bt_dev_err(hdev, "Suspend timeout bit: %d", i);
		clear_bit(i, hdev->suspend_tasks);
		}

		@@ -3360,12 +3360,15 @@ static int hci_suspend_notifier(struct notifier_block *nb, unsigned long action,
		ret = hci_change_suspend_state(hdev, BT_RUNNING);
		}

		/* If suspend failed, restore it to running */
		if (ret && action == PM_SUSPEND_PREPARE)
		hci_change_suspend_state(hdev, BT_RUNNING);

		done:
		return ret ? notifier_from_errno(-EBUSY) : NOTIFY_STOP;
		/* We always allow suspend even if suspend preparation failed and
		* attempt to recover in resume.
		*/
		if (ret)
		bt_dev_err(hdev, "Suspend notifier action (%lu) failed: %d",
		action, ret);

		return NOTIFY_STOP;
		}

		/* Alloc HCI device */

Admin message