Commit a9eaa813 authored Oct 17, 2014 by Guenter Roeck Committed by Mark Brown Mar 27, 2015

regulator: Ensure unique regulator debugfs directory names



If multiple regulator devices of the same type exist in a system,
the regulator driver assigns generic names for the regulators it
provides, and debugfs is enabled, the regulator subsystem attempts
to create multiple entries with the same name in the regulator debugfs
directory. This fails for all but the first regulator, resulting in
multiple "Failed to create debugfs directory" log entries.

To avoid the problem, prepend the debugfs directory name for a regulator
with its parent device name if available, but only if no explicit
regulator name was provided.

Cc: Alan Tull <atull@opensource.altera.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent c517d838

drivers/regulator/core.c

+12 −1

Original line number	Diff line number	Diff line
		@@ -3502,7 +3502,18 @@ static struct class regulator_class = {

		static void rdev_init_debugfs(struct regulator_dev *rdev)
		{
		rdev->debugfs = debugfs_create_dir(rdev_get_name(rdev), debugfs_root);
		struct device *parent = rdev->dev.parent;
		const char *rname = rdev_get_name(rdev);
		char name[NAME_MAX];

		/* Avoid duplicate debugfs directory names */
		if (parent && rname == rdev->desc->name) {
		snprintf(name, sizeof(name), "%s-%s", dev_name(parent),
		rname);
		rname = name;
		}

		rdev->debugfs = debugfs_create_dir(rname, debugfs_root);
		if (!rdev->debugfs) {
		rdev_warn(rdev, "Failed to create debugfs directory\n");
		return;

Admin message