Commit a9e062d0 authored by Christophe Ricard's avatar Christophe Ricard Committed by Samuel Ortiz
Browse files

NFC: st21nfca: Add error messages for unexpected HCI events 



Potentially an unexpected HCI event may occur because of a
firmware bug. It could be transparent for the user but we should
at least log it.

Signed-off-by: default avatarChristophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 57dc828a

drivers/nfc/st21nfca/core.c

+2 −0
Original line number Diff line number Diff line
@@ -893,6 +893,8 @@ static int st21nfca_admin_event_received(struct nfc_hci_dev *hdev, u8 event, 
			}

		}

	break;

	default:

		nfc_err(&hdev->ndev->dev, "Unexpected event on admin gate\n");

	}

	kfree_skb(skb);

	return 0;

drivers/nfc/st21nfca/dep.c

+1 −0
Original line number Diff line number Diff line
@@ -435,6 +435,7 @@ int st21nfca_dep_event_received(struct nfc_hci_dev *hdev, 
			return r;

		return 0;

	default:

		nfc_err(&hdev->ndev->dev, "Unexpected event on card f gate\n");

		return 1;

	}

	kfree_skb(skb);

drivers/nfc/st21nfca/se.c

+4 −0
Original line number Diff line number Diff line
@@ -342,6 +342,7 @@ int st21nfca_connectivity_event_received(struct nfc_hci_dev *hdev, u8 host, 
		r = nfc_se_transaction(hdev->ndev, host, transaction);

		break;

	default:

		nfc_err(&hdev->ndev->dev, "Unexpected event on connectivity gate\n");

		return 1;

	}

	kfree_skb(skb);
@@ -373,6 +374,9 @@ int st21nfca_apdu_reader_event_received(struct nfc_hci_dev *hdev, 
		mod_timer(&info->se_info.bwi_timer, jiffies +

				msecs_to_jiffies(info->se_info.wt_timeout));

		break;

	default:

		nfc_err(&hdev->ndev->dev, "Unexpected event on apdu reader gate\n");

		return 1;

	}



exit:

CRA Git | Maintained and supported by SUSTech CRA and CCSE