Commit a9d99388 authored Jan 04, 2012 by Dan Carpenter Committed by Ben Skeggs Feb 01, 2012

drm/nv50/pm: signedness bug in nv50_pm_clocks_pre()



calc_mclk() returns zero on success and negative on failure but clk is
a u32.

v2: Martin Peres:
- clk should be an int, not a u32

Signed-off-by: Martin Peres <martin.peres@labri.fr>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent 525895ba

drivers/gpu/drm/nouveau/nv50_pm.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -495,9 +495,9 @@ nv50_pm_clocks_pre(struct drm_device dev, struct nouveau_pm_level perflvl)
		struct drm_nouveau_private *dev_priv = dev->dev_private;
		struct nv50_pm_state *info;
		struct pll_lims pll;
		int ret = -EINVAL;
		int clk, ret = -EINVAL;
		int N, M, P1, P2;
		u32 clk, out;
		u32 out;

		if (dev_priv->chipset == 0xaa \|\|
		dev_priv->chipset == 0xac)

Admin message