Commit a9bb7e62 authored by Vladimir Davydov's avatar Vladimir Davydov Committed by Linus Torvalds
Browse files

memcg: only account kmem allocations marked as __GFP_ACCOUNT 



Black-list kmem accounting policy (aka __GFP_NOACCOUNT) turned out to be
fragile and difficult to maintain, because there seem to be many more
allocations that should not be accounted than those that should be.
Besides, false accounting an allocation might result in much worse
consequences than not accounting at all, namely increased memory
consumption due to pinned dead kmem caches.

So this patch switches kmem accounting to the white-policy: now only
those kmem allocations that are marked as __GFP_ACCOUNT are accounted to
memcg.  Currently, no kmem allocations are marked like this.  The
following patches will mark several kmem allocations that are known to
be easily triggered from userspace and therefore should be accounted to
memcg.

Signed-off-by: default avatarVladimir Davydov <vdavydov@virtuozzo.com>
Acked-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Greg Thelen <gthelen@google.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 20b5c303

include/linux/gfp.h

+9 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ struct vm_area_struct; 
#define ___GFP_HARDWALL		0x20000u

#define ___GFP_THISNODE		0x40000u

#define ___GFP_ATOMIC		0x80000u

#define ___GFP_ACCOUNT		0x100000u

#define ___GFP_NOTRACK		0x200000u

#define ___GFP_DIRECT_RECLAIM	0x400000u

#define ___GFP_OTHER_NODE	0x800000u
@@ -72,11 +73,15 @@ struct vm_area_struct; 
 *

 * __GFP_THISNODE forces the allocation to be satisified from the requested

 *   node with no fallbacks or placement policy enforcements.

 *

 * __GFP_ACCOUNT causes the allocation to be accounted to kmemcg (only relevant

 *   to kmem allocations).

 */

#define __GFP_RECLAIMABLE ((__force gfp_t)___GFP_RECLAIMABLE)

#define __GFP_WRITE	((__force gfp_t)___GFP_WRITE)

#define __GFP_HARDWALL   ((__force gfp_t)___GFP_HARDWALL)

#define __GFP_THISNODE	((__force gfp_t)___GFP_THISNODE)

#define __GFP_ACCOUNT	((__force gfp_t)___GFP_ACCOUNT)



/*

 * Watermark modifiers -- controls access to emergency reserves
@@ -195,6 +200,9 @@ struct vm_area_struct; 
 * GFP_KERNEL is typical for kernel-internal allocations. The caller requires

 *   ZONE_NORMAL or a lower zone for direct access but can direct reclaim.

 *

 * GFP_KERNEL_ACCOUNT is the same as GFP_KERNEL, except the allocation is

 *   accounted to kmemcg.

 *

 * GFP_NOWAIT is for kernel allocations that should not stall for direct

 *   reclaim, start physical IO or use any filesystem callback.

 *
@@ -234,6 +242,7 @@ struct vm_area_struct; 
 */

#define GFP_ATOMIC	(__GFP_HIGH|__GFP_ATOMIC|__GFP_KSWAPD_RECLAIM)

#define GFP_KERNEL	(__GFP_RECLAIM | __GFP_IO | __GFP_FS)

#define GFP_KERNEL_ACCOUNT (GFP_KERNEL | __GFP_ACCOUNT)

#define GFP_NOWAIT	(__GFP_KSWAPD_RECLAIM)

#define GFP_NOIO	(__GFP_RECLAIM)

#define GFP_NOFS	(__GFP_RECLAIM | __GFP_IO)

include/linux/memcontrol.h

+2 −0
Original line number Diff line number Diff line
@@ -773,6 +773,8 @@ static inline bool __memcg_kmem_bypass(gfp_t gfp) 
{

	if (!memcg_kmem_enabled())

		return true;

	if (!(gfp & __GFP_ACCOUNT))

		return true;

	if (in_interrupt() || (!current->mm) || (current->flags & PF_KTHREAD))

		return true;

	return false;

mm/page_alloc.c

+2 −1
Original line number Diff line number Diff line
@@ -3402,7 +3402,8 @@ EXPORT_SYMBOL(__free_page_frag); 


/*

 * alloc_kmem_pages charges newly allocated pages to the kmem resource counter

 * of the current memory cgroup.

 * of the current memory cgroup if __GFP_ACCOUNT is set, other than that it is

 * equivalent to alloc_pages.

 *

 * It should be used when the caller would like to use kmalloc, but since the

 * allocation is large, it has to fall back to the page allocator.

CRA Git | Maintained and supported by SUSTech CRA and CCSE