Unverified Commit a9a9cbf0 authored Apr 15, 2020 by Pan Xiuli Committed by Mark Brown Apr 16, 2020

ASoC: SOF: make sof_ipc_cc_version to fixed length

Align struct sof_ipc_cc_version to firmware definition in SOF ABI 3.15.0.

The struct definition was changed due to errors in FW build.
The Cadence XCC compiler produces incorrect linkage section sizes, when a
variable length array is used in the compiler version struct. The firmware
definition was changed to a fixed 32 byte compiler description string.
This length covers all released firmware binaries and thus only a minor
ABI change is needed.

As the same structure is used in IPC messages between driver and firmware,
the kernel needs to be aligned to firmware change.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200415202816.934-15-pierre-louis.bossart@linux.intel.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent 60829341

include/sound/sof/info.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -113,7 +113,7 @@ struct sof_ipc_cc_version {

		uint8_t name[16]; /* null terminated compiler name */
		uint8_t optim[4]; /* null terminated compiler -O flag value */
		uint8_t desc[]; /* null terminated compiler description */
		uint8_t desc[32]; /* null terminated compiler description */
		} __packed;

		/* extended data: Probe setup */

+1 −1

Original line number	Diff line number	Diff line
		@@ -26,7 +26,7 @@

		/* SOF ABI version major, minor and patch numbers */
		#define SOF_ABI_MAJOR 3
		#define SOF_ABI_MINOR 14
		#define SOF_ABI_MINOR 15
		#define SOF_ABI_PATCH 0

		/* SOF ABI version number. Format within 32bit word is MMmmmppp */