Commit a9a6cb4f authored Mar 12, 2016 by Bhaktipriya Shridhar Committed by Greg Kroah-Hartman Mar 11, 2016

staging: lustre: lnet: conrpc: Use list_for_each_entry_safe



Doubly linked lists which are  iterated  using list_empty
and list_entry macros have been replaced with list_for_each_entry_safe
macro.
This makes the iteration simpler and more readable.

This patch replaces the while loop containing list_empty and list_entry
with list_for_each_entry_safe.

This was done with Coccinelle.

@@
expression E1;
identifier I1, I2;
type T;
iterator name list_for_each_entry_safe;
@@

T *I1;
+ T *tmp;
...
- while (list_empty(&E1) == 0)
+ list_for_each_entry_safe (I1, tmp, &E1, I2)
{
...when != T *I1;
- I1 = list_entry(E1.next, T, I2);
...
}

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 24f69590

drivers/staging/lustre/lnet/selftest/conrpc.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1335,6 +1335,7 @@ lstcon_rpc_cleanup_wait(void)
		{
		lstcon_rpc_trans_t *trans;
		lstcon_rpc_t *crpc;
		lstcon_rpc_t *temp;
		struct list_head *pacer;
		struct list_head zlist;

		@@ -1374,9 +1375,7 @@ lstcon_rpc_cleanup_wait(void)

		spin_unlock(&console_session.ses_rpc_lock);

		while (!list_empty(&zlist)) {
		crpc = list_entry(zlist.next, lstcon_rpc_t, crp_link);

		list_for_each_entry_safe(crpc, temp, &zlist, crp_link) {
		list_del(&crpc->crp_link);
		LIBCFS_FREE(crpc, sizeof(lstcon_rpc_t));
		}

Admin message