Commit a99042e7 authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Wolfram Sang
Browse files

i2c: tegra: Clean up variable names 



Rename "ret" variables to "err" in order to make code a bit more
expressive, emphasizing that the returned value is an error code.
Same vice versa, where appropriate.

Rename variable "reg" to "val" in order to better reflect the actual
usage of the variable in the code and to make naming consistent with
the rest of the code.

Use briefer names for a few members of the tegra_i2c_dev structure in
order to improve readability of the code.

All dev/&pdev->dev are replaced with i2c_dev->dev in order to have uniform
code style across the driver.

Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Tested-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarDmitry Osipenko <digetx@gmail.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 89e3748a

drivers/i2c/busses/i2c-tegra.c

+90 −87
Original line number Diff line number Diff line
@@ -247,15 +247,15 @@ struct tegra_i2c_hw_feature { 
 * @msg_buf_remaining: size of unsent data in the message buffer

 * @msg_read: identifies read transfers

 * @bus_clk_rate: current I2C bus clock rate

 * @is_multimaster_mode: track if I2C controller is in multi-master mode

 * @multimaster_mode: indicates that I2C controller is in multi-master mode

 * @tx_dma_chan: DMA transmit channel

 * @rx_dma_chan: DMA receive channel

 * @dma_phys: handle to DMA resources

 * @dma_buf: pointer to allocated DMA buffer

 * @dma_buf_size: DMA buffer size

 * @is_curr_dma_xfer: indicates active DMA transfer

 * @dma_mode: indicates active DMA transfer

 * @dma_complete: DMA completion notifier

 * @is_curr_atomic_xfer: indicates active atomic transfer

 * @atomic_mode: indicates active atomic transfer

 */

struct tegra_i2c_dev {

	struct device *dev;
@@ -287,9 +287,9 @@ struct tegra_i2c_dev { 
	dma_addr_t dma_phys;

	void *dma_buf;



	bool is_multimaster_mode;

	bool is_curr_atomic_xfer;

	bool is_curr_dma_xfer;

	bool multimaster_mode;

	bool atomic_mode;

	bool dma_mode;

	bool msg_read;

	bool is_dvc;

	bool is_vi;
@@ -526,7 +526,7 @@ static int tegra_i2c_poll_register(struct tegra_i2c_dev *i2c_dev, 
	void __iomem *addr = i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg);

	u32 val;



	if (!i2c_dev->is_curr_atomic_xfer)

	if (!i2c_dev->atomic_mode)

		return readl_relaxed_poll_timeout(addr, val, !(val & mask),

						  delay_us, timeout_us);
@@ -674,7 +674,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) 
	if (err)

		return err;



	if (i2c_dev->is_multimaster_mode && i2c_dev->hw->has_slcg_override_reg)

	if (i2c_dev->multimaster_mode && i2c_dev->hw->has_slcg_override_reg)

		i2c_writel(i2c_dev, I2C_MST_CORE_CLKEN_OVR, I2C_CLKEN_OVERRIDE);



	err = tegra_i2c_wait_for_config_load(i2c_dev);
@@ -860,7 +860,7 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id) 
	if (i2c_dev->hw->supports_bus_clear && (status & I2C_INT_BUS_CLR_DONE))

		goto err;



	if (!i2c_dev->is_curr_dma_xfer) {

	if (!i2c_dev->dma_mode) {

		if (i2c_dev->msg_read && (status & I2C_INT_RX_FIFO_DATA_REQ)) {

			if (tegra_i2c_empty_rx_fifo(i2c_dev)) {

				/*
@@ -894,7 +894,7 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id) 
	 * so forcing msg_buf_remaining to 0 in DMA mode.

	 */

	if (status & I2C_INT_PACKET_XFER_COMPLETE) {

		if (i2c_dev->is_curr_dma_xfer)

		if (i2c_dev->dma_mode)

			i2c_dev->msg_buf_remaining = 0;

		/*

		 * Underflow error condition: XFER_COMPLETE before message
@@ -918,7 +918,7 @@ err: 
	if (i2c_dev->is_dvc)

		dvc_writel(i2c_dev, DVC_STATUS_I2C_DONE_INTR, DVC_STATUS);



	if (i2c_dev->is_curr_dma_xfer) {

	if (i2c_dev->dma_mode) {

		if (i2c_dev->msg_read)

			dmaengine_terminate_async(i2c_dev->rx_dma_chan);

		else
@@ -938,14 +938,14 @@ static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev, 
	struct dma_slave_config slv_config = {0};

	u32 val, reg, dma_burst, reg_offset;

	struct dma_chan *chan;

	int ret;

	int err;



	if (i2c_dev->hw->has_mst_fifo)

		reg = I2C_MST_FIFO_CONTROL;

	else

		reg = I2C_FIFO_CONTROL;



	if (i2c_dev->is_curr_dma_xfer) {

	if (i2c_dev->dma_mode) {

		if (len & 0xF)

			dma_burst = 1;

		else if (len & 0x10)
@@ -978,13 +978,13 @@ static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev, 
		}



		slv_config.device_fc = true;

		ret = dmaengine_slave_config(chan, &slv_config);

		if (ret) {

		err = dmaengine_slave_config(chan, &slv_config);

		if (err) {

			dev_err(i2c_dev->dev, "DMA slave config failed: %d\n",

				ret);

				err);

			dev_err(i2c_dev->dev, "falling back to PIO\n");

			tegra_i2c_release_dma(i2c_dev);

			i2c_dev->is_curr_dma_xfer = false;

			i2c_dev->dma_mode = false;

		} else {

			goto out;

		}
@@ -1032,7 +1032,7 @@ static unsigned long tegra_i2c_wait_completion(struct tegra_i2c_dev *i2c_dev, 
{

	unsigned long ret;



	if (i2c_dev->is_curr_atomic_xfer) {

	if (i2c_dev->atomic_mode) {

		ret = tegra_i2c_poll_completion(i2c_dev, complete, timeout_ms);

	} else {

		enable_irq(i2c_dev->irq);
@@ -1060,20 +1060,20 @@ static unsigned long tegra_i2c_wait_completion(struct tegra_i2c_dev *i2c_dev, 
static int tegra_i2c_issue_bus_clear(struct i2c_adapter *adap)

{

	struct tegra_i2c_dev *i2c_dev = i2c_get_adapdata(adap);

	u32 reg, time_left;

	u32 val, time_left;

	int err;



	reinit_completion(&i2c_dev->msg_complete);

	reg = FIELD_PREP(I2C_BC_SCLK_THRESHOLD, 9) | I2C_BC_STOP_COND |

	val = FIELD_PREP(I2C_BC_SCLK_THRESHOLD, 9) | I2C_BC_STOP_COND |

	      I2C_BC_TERMINATE;

	i2c_writel(i2c_dev, reg, I2C_BUS_CLEAR_CNFG);

	i2c_writel(i2c_dev, val, I2C_BUS_CLEAR_CNFG);



	err = tegra_i2c_wait_for_config_load(i2c_dev);

	if (err)

		return err;



	reg |= I2C_BC_ENABLE;

	i2c_writel(i2c_dev, reg, I2C_BUS_CLEAR_CNFG);

	val |= I2C_BC_ENABLE;

	i2c_writel(i2c_dev, val, I2C_BUS_CLEAR_CNFG);

	tegra_i2c_unmask_irq(i2c_dev, I2C_INT_BUS_CLR_DONE);



	time_left = tegra_i2c_wait_completion(i2c_dev, &i2c_dev->msg_complete, 50);
@@ -1084,8 +1084,8 @@ static int tegra_i2c_issue_bus_clear(struct i2c_adapter *adap) 
		return -ETIMEDOUT;

	}



	reg = i2c_readl(i2c_dev, I2C_BUS_CLEAR_STATUS);

	if (!(reg & I2C_BC_STATUS)) {

	val = i2c_readl(i2c_dev, I2C_BUS_CLEAR_STATUS);

	if (!(val & I2C_BC_STATUS)) {

		dev_err(i2c_dev->dev,

			"un-recovered arbitration lost\n");

		return -EIO;
@@ -1107,14 +1107,14 @@ static void tegra_i2c_push_packet_header(struct tegra_i2c_dev *i2c_dev, 
			FIELD_PREP(PACKET_HEADER0_CONT_ID, i2c_dev->cont_id) |

			FIELD_PREP(PACKET_HEADER0_PACKET_ID, 1);



	if (i2c_dev->is_curr_dma_xfer && !i2c_dev->msg_read)

	if (i2c_dev->dma_mode && !i2c_dev->msg_read)

		*dma_buf++ = packet_header;

	else

		i2c_writel(i2c_dev, packet_header, I2C_TX_FIFO);



	packet_header = msg->len - 1;



	if (i2c_dev->is_curr_dma_xfer && !i2c_dev->msg_read)

	if (i2c_dev->dma_mode && !i2c_dev->msg_read)

		*dma_buf++ = packet_header;

	else

		i2c_writel(i2c_dev, packet_header, I2C_TX_FIFO);
@@ -1139,7 +1139,7 @@ static void tegra_i2c_push_packet_header(struct tegra_i2c_dev *i2c_dev, 
	if (msg->flags & I2C_M_RD)

		packet_header |= I2C_HEADER_READ;



	if (i2c_dev->is_curr_dma_xfer && !i2c_dev->msg_read)

	if (i2c_dev->dma_mode && !i2c_dev->msg_read)

		*dma_buf++ = packet_header;

	else

		i2c_writel(i2c_dev, packet_header, I2C_TX_FIFO);
@@ -1155,7 +1155,7 @@ static int tegra_i2c_error_recover(struct tegra_i2c_dev *i2c_dev, 


	/* start recovery upon arbitration loss in single master mode */

	if (i2c_dev->msg_err == I2C_ERR_ARBITRATION_LOST) {

		if (!i2c_dev->is_multimaster_mode)

		if (!i2c_dev->multimaster_mode)

			return i2c_recover_bus(&i2c_dev->adapter);



		return -EAGAIN;
@@ -1196,9 +1196,9 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 
		xfer_size = msg->len + I2C_PACKET_HEADER_SIZE;



	xfer_size = ALIGN(xfer_size, BYTES_PER_FIFO_WORD);

	i2c_dev->is_curr_dma_xfer = (xfer_size > I2C_PIO_MODE_PREFERRED_LEN) &&

				    i2c_dev->dma_buf &&

				    !i2c_dev->is_curr_atomic_xfer;

	i2c_dev->dma_mode = (xfer_size > I2C_PIO_MODE_PREFERRED_LEN) &&

			    i2c_dev->dma_buf && !i2c_dev->atomic_mode;



	tegra_i2c_config_fifo_trig(i2c_dev, xfer_size);



	/*
@@ -1210,7 +1210,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 


	int_mask = I2C_INT_NO_ACK | I2C_INT_ARBITRATION_LOST;

	tegra_i2c_unmask_irq(i2c_dev, int_mask);

	if (i2c_dev->is_curr_dma_xfer) {

	if (i2c_dev->dma_mode) {

		if (i2c_dev->msg_read) {

			dma_sync_single_for_device(i2c_dev->dev,

						   i2c_dev->dma_phys,
@@ -1235,7 +1235,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 
	tegra_i2c_push_packet_header(i2c_dev, msg, end_state);



	if (!i2c_dev->msg_read) {

		if (i2c_dev->is_curr_dma_xfer) {

		if (i2c_dev->dma_mode) {

			memcpy(i2c_dev->dma_buf + I2C_PACKET_HEADER_SIZE,

			       msg->buf, msg->len);

			dma_sync_single_for_device(i2c_dev->dev,
@@ -1256,7 +1256,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 


	if (i2c_dev->hw->has_per_pkt_xfer_complete_irq)

		int_mask |= I2C_INT_PACKET_XFER_COMPLETE;

	if (!i2c_dev->is_curr_dma_xfer) {

	if (!i2c_dev->dma_mode) {

		if (msg->flags & I2C_M_RD)

			int_mask |= I2C_INT_RX_FIFO_DATA_REQ;

		else if (i2c_dev->msg_buf_remaining)
@@ -1267,7 +1267,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 
	dev_dbg(i2c_dev->dev, "unmasked irq: %02x\n",

		i2c_readl(i2c_dev, I2C_INT_MASK));



	if (i2c_dev->is_curr_dma_xfer) {

	if (i2c_dev->dma_mode) {

		time_left = tegra_i2c_wait_completion(i2c_dev,

						      &i2c_dev->dma_complete,

						      xfer_time);
@@ -1316,7 +1316,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, 
		time_left, completion_done(&i2c_dev->msg_complete),

		i2c_dev->msg_err);



	i2c_dev->is_curr_dma_xfer = false;

	i2c_dev->dma_mode = false;



	err = tegra_i2c_error_recover(i2c_dev, msg);

	if (err)
@@ -1363,9 +1363,9 @@ static int tegra_i2c_xfer_atomic(struct i2c_adapter *adap, 
	struct tegra_i2c_dev *i2c_dev = i2c_get_adapdata(adap);

	int ret;



	i2c_dev->is_curr_atomic_xfer = true;

	i2c_dev->atomic_mode = true;

	ret = tegra_i2c_xfer(adap, msgs, num);

	i2c_dev->is_curr_atomic_xfer = false;

	i2c_dev->atomic_mode = false;



	return ret;

}
@@ -1590,15 +1590,15 @@ static void tegra_i2c_parse_dt(struct tegra_i2c_dev *i2c_dev) 
{

	struct device_node *np = i2c_dev->dev->of_node;

	bool multi_mode;

	int ret;

	int err;



	ret = of_property_read_u32(np, "clock-frequency",

	err = of_property_read_u32(np, "clock-frequency",

				   &i2c_dev->bus_clk_rate);

	if (ret)

	if (err)

		i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ; /* default clock rate */



	multi_mode = of_property_read_bool(np, "multi-master");

	i2c_dev->is_multimaster_mode = multi_mode;

	i2c_dev->multimaster_mode = multi_mode;



	if (of_device_is_compatible(np, "nvidia,tegra20-i2c-dvc"))

		i2c_dev->is_dvc = true;
@@ -1630,7 +1630,7 @@ static int tegra_i2c_init_clocks(struct tegra_i2c_dev *i2c_dev) 


	i2c_dev->div_clk = i2c_dev->clocks[0].clk;



	if (!i2c_dev->is_multimaster_mode)

	if (!i2c_dev->multimaster_mode)

		return 0;



	err = clk_enable(i2c_dev->div_clk);
@@ -1649,7 +1649,7 @@ unprepare_clocks: 


static void tegra_i2c_release_clocks(struct tegra_i2c_dev *i2c_dev)

{

	if (i2c_dev->is_multimaster_mode)

	if (i2c_dev->multimaster_mode)

		clk_disable(i2c_dev->div_clk);



	clk_bulk_unprepare(i2c_dev->nclocks, i2c_dev->clocks);
@@ -1674,7 +1674,7 @@ static int tegra_i2c_probe(struct platform_device *pdev) 
{

	struct tegra_i2c_dev *i2c_dev;

	struct resource *res;

	int ret;

	int err;



	i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL);

	if (!i2c_dev)
@@ -1695,36 +1695,36 @@ static int tegra_i2c_probe(struct platform_device *pdev) 


	i2c_dev->base_phys = res->start;



	ret = platform_get_irq(pdev, 0);

	if (ret < 0)

		return ret;

	err = platform_get_irq(pdev, 0);

	if (err < 0)

		return err;



	i2c_dev->irq = ret;

	i2c_dev->irq = err;



	/* interrupt will be enabled during of transfer time */

	irq_set_status_flags(i2c_dev->irq, IRQ_NOAUTOEN);



	ret = devm_request_irq(&pdev->dev, i2c_dev->irq, tegra_i2c_isr,

			       IRQF_NO_SUSPEND, dev_name(&pdev->dev),

	err = devm_request_irq(i2c_dev->dev, i2c_dev->irq, tegra_i2c_isr,

			       IRQF_NO_SUSPEND, dev_name(i2c_dev->dev),

			       i2c_dev);

	if (ret)

		return ret;

	if (err)

		return err;



	i2c_dev->rst = devm_reset_control_get_exclusive(&pdev->dev, "i2c");

	i2c_dev->rst = devm_reset_control_get_exclusive(i2c_dev->dev, "i2c");

	if (IS_ERR(i2c_dev->rst)) {

		dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->rst),

		dev_err_probe(i2c_dev->dev, PTR_ERR(i2c_dev->rst),

			      "failed to get reset control\n");

		return PTR_ERR(i2c_dev->rst);

	}



	tegra_i2c_parse_dt(i2c_dev);



	ret = tegra_i2c_init_clocks(i2c_dev);

	if (ret)

		return ret;

	err = tegra_i2c_init_clocks(i2c_dev);

	if (err)

		return err;



	ret = tegra_i2c_init_dma(i2c_dev);

	if (ret)

	err = tegra_i2c_init_dma(i2c_dev);

	if (err)

		goto release_clocks;



	/*
@@ -1735,16 +1735,16 @@ static int tegra_i2c_probe(struct platform_device *pdev) 
	 * not be used for atomic transfers.

	 */

	if (!i2c_dev->is_vi)

		pm_runtime_irq_safe(&pdev->dev);

	pm_runtime_enable(&pdev->dev);

		pm_runtime_irq_safe(i2c_dev->dev);

	pm_runtime_enable(i2c_dev->dev);



	ret = tegra_i2c_init_hardware(i2c_dev);

	if (ret)

	err = tegra_i2c_init_hardware(i2c_dev);

	if (err)

		goto release_rpm;



	i2c_set_adapdata(&i2c_dev->adapter, i2c_dev);

	i2c_dev->adapter.dev.of_node = pdev->dev.of_node;

	i2c_dev->adapter.dev.parent = &pdev->dev;

	i2c_dev->adapter.dev.of_node = i2c_dev->dev->of_node;

	i2c_dev->adapter.dev.parent = i2c_dev->dev;

	i2c_dev->adapter.retries = 1;

	i2c_dev->adapter.timeout = 6 * HZ;

	i2c_dev->adapter.quirks = i2c_dev->hw->quirks;
@@ -1756,23 +1756,23 @@ static int tegra_i2c_probe(struct platform_device *pdev) 
	if (i2c_dev->hw->supports_bus_clear)

		i2c_dev->adapter.bus_recovery_info = &tegra_i2c_recovery_info;



	strlcpy(i2c_dev->adapter.name, dev_name(&pdev->dev),

	strlcpy(i2c_dev->adapter.name, dev_name(i2c_dev->dev),

		sizeof(i2c_dev->adapter.name));



	ret = i2c_add_numbered_adapter(&i2c_dev->adapter);

	if (ret)

	err = i2c_add_numbered_adapter(&i2c_dev->adapter);

	if (err)

		goto release_rpm;



	return 0;



release_rpm:

	pm_runtime_disable(&pdev->dev);

	pm_runtime_disable(i2c_dev->dev);



	tegra_i2c_release_dma(i2c_dev);

release_clocks:

	tegra_i2c_release_clocks(i2c_dev);



	return ret;

	return err;

}



static int tegra_i2c_remove(struct platform_device *pdev)
@@ -1781,7 +1781,7 @@ static int tegra_i2c_remove(struct platform_device *pdev) 


	i2c_del_adapter(&i2c_dev->adapter);



	pm_runtime_disable(&pdev->dev);

	pm_runtime_disable(i2c_dev->dev);



	tegra_i2c_release_dma(i2c_dev);

	tegra_i2c_release_clocks(i2c_dev);
@@ -1791,15 +1791,15 @@ static int tegra_i2c_remove(struct platform_device *pdev) 
static int __maybe_unused tegra_i2c_runtime_resume(struct device *dev)

{

	struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);

	int ret;

	int err;



	ret = pinctrl_pm_select_default_state(i2c_dev->dev);

	if (ret)

		return ret;

	err = pinctrl_pm_select_default_state(dev);

	if (err)

		return err;



	ret = clk_bulk_enable(i2c_dev->nclocks, i2c_dev->clocks);

	if (ret)

		return ret;

	err = clk_bulk_enable(i2c_dev->nclocks, i2c_dev->clocks);

	if (err)

		return err;



	/*

	 * VI I2C device is attached to VE power domain which goes through
@@ -1808,8 +1808,8 @@ static int __maybe_unused tegra_i2c_runtime_resume(struct device *dev) 
	 * domain ON.

	 */

	if (i2c_dev->is_vi) {

		ret = tegra_i2c_init(i2c_dev);

		if (ret)

		err = tegra_i2c_init(i2c_dev);

		if (err)

			goto disable_clocks;

	}
@@ -1818,7 +1818,7 @@ static int __maybe_unused tegra_i2c_runtime_resume(struct device *dev) 
disable_clocks:

	clk_bulk_disable(i2c_dev->nclocks, i2c_dev->clocks);



	return ret;

	return err;

}



static int __maybe_unused tegra_i2c_runtime_suspend(struct device *dev)
@@ -1827,22 +1827,25 @@ static int __maybe_unused tegra_i2c_runtime_suspend(struct device *dev) 


	clk_bulk_disable(i2c_dev->nclocks, i2c_dev->clocks);



	return pinctrl_pm_select_idle_state(i2c_dev->dev);

	return pinctrl_pm_select_idle_state(dev);

}



static int __maybe_unused tegra_i2c_suspend(struct device *dev)

{

	struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);

	int err = 0;

	int err;



	i2c_mark_adapter_suspended(&i2c_dev->adapter);



	if (!pm_runtime_status_suspended(dev))

	if (!pm_runtime_status_suspended(dev)) {

		err = tegra_i2c_runtime_suspend(dev);



		if (err)

			return err;

	}



	return 0;

}



static int __maybe_unused tegra_i2c_resume(struct device *dev)

{

	struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE