Commit a9844881 authored Apr 08, 2016 by Jiri Pirko Committed by David S. Miller Apr 08, 2016

devlink: remove implicit type set in port register



As we rely on caller zeroing or correctly set the struct before the call,
this implicit type set is either no-op (DEVLINK_PORT_TYPE_NOTSET is 0)
or it rewrites wanted value. So remove this.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 24d390b2

net/core/devlink.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -630,7 +630,6 @@ int devlink_port_register(struct devlink *devlink,
		}
		devlink_port->devlink = devlink;
		devlink_port->index = port_index;
		devlink_port->type = DEVLINK_PORT_TYPE_NOTSET;
		devlink_port->registered = true;
		list_add_tail(&devlink_port->list, &devlink->port_list);
		mutex_unlock(&devlink_port_mutex);

Admin message