Commit a9814d7f authored Oct 17, 2019 by Bodong Wang Committed by Saeed Mahameed Mar 13, 2020

net/mlx5: E-Switch, Remove redundant warning when QoS enable failed



esw_vport_enable_qos can return error in cases below:
1. QoS is already enabled. Warnning is useless in this case.
2. Create scheduling element cmd failed. There is already a warning.

Remove the redundant warnning if esw_vport_enable_qos returns err.

Signed-off-by: Bodong Wang <bodong@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 14c844cb

drivers/net/ethernet/mellanox/mlx5/core/eswitch.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1801,9 +1801,7 @@ static int esw_enable_vport(struct mlx5_eswitch esw, struct mlx5_vport vport,
		goto done;

		/* Attach vport to the eswitch rate limiter */
		if (esw_vport_enable_qos(esw, vport, vport->info.max_rate,
		vport->qos.bw_share))
		esw_warn(esw->dev, "Failed to attach vport %d to eswitch rate limiter", vport_num);
		esw_vport_enable_qos(esw, vport, vport->info.max_rate, vport->qos.bw_share);

		/* Sync with current vport context */
		vport->enabled_events = enabled_events;

Admin message