Commit a97234e1 authored by Minwoo Im's avatar Minwoo Im Committed by Christoph Hellwig
Browse files

nvme-pci: check more command sizes 



All the NVMe command has 64bytes fixed size so that it has been assured
with BUILD_BUG_ON().  The remaining command structures in linux/nvme.h
also need to be checked here.

Signed-off-by: default avatarMinwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 66564867

drivers/nvme/host/pci.c

+7 −0
Original line number Diff line number Diff line
@@ -231,19 +231,26 @@ struct nvme_iod { 
 */

static inline void _nvme_check_size(void)

{

	BUILD_BUG_ON(sizeof(struct nvme_common_command) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_rw_command) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_identify) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_create_cq) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_create_sq) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_delete_queue) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_features) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_download_firmware) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_format_cmd) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_dsm_cmd) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_write_zeroes_cmd) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_abort_cmd) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_get_log_page_command) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_command) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_id_ctrl) != NVME_IDENTIFY_DATA_SIZE);

	BUILD_BUG_ON(sizeof(struct nvme_id_ns) != NVME_IDENTIFY_DATA_SIZE);

	BUILD_BUG_ON(sizeof(struct nvme_lba_range_type) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_smart_log) != 512);

	BUILD_BUG_ON(sizeof(struct nvme_dbbuf) != 64);

	BUILD_BUG_ON(sizeof(struct nvme_directive_cmd) != 64);

}



static unsigned int max_io_queues(void)

CRA Git | Maintained and supported by SUSTech CRA and CCSE