Commit a9685338 authored Oct 27, 2009 by Kalle Valo Committed by John W. Linville Oct 30, 2009

mac80211: fix dynamic power save for devices with nullfunc support in hw



In TX path it was assumed that dynamic power save works only if
IEEE80211_HW_PS_NULLFUNC_STACK is set. But is not the case, there are
devices which have nullfunc support in hardware but need mac80211
to handle dynamic power save timers, TI's wl1251 is one of them.

The fix is to not check for IEEE80211_HW_PS_NULLFUNC_STACK in
is_dynamic_ps_enabled(), instead check IEEE80211_HW_SUPPORTS_PS and
IEEE80211_HW_SUPPORTS_DYNAMIC_PS flags and act accordingly.

Tested with wl1251.

Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent ed620590

net/mac80211/tx.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1390,7 +1390,11 @@ static int ieee80211_skb_resize(struct ieee80211_local *local,
		static bool need_dynamic_ps(struct ieee80211_local *local)
		{
		/* driver doesn't support power save */
		if (!(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK))
		if (!(local->hw.flags & IEEE80211_HW_SUPPORTS_PS))
		return false;

		/* hardware does dynamic power save */
		if (local->hw.flags & IEEE80211_HW_SUPPORTS_DYNAMIC_PS)
		return false;

		/* dynamic power save disabled */

Admin message