Commit a9677833 authored Jul 21, 2019 by Hariprasad Kelam Committed by Martin K. Petersen Aug 19, 2019

scsi: lpfc: remove NULL check before some freeing functions



As dma_pool_destroy and mempool_destroy functions has NULL check. We may
not need NULL check before calling them.

Fix below warnings reported by coccicheck
./drivers/scsi/lpfc/lpfc_mem.c:252:2-18: WARNING: NULL check before some
freeing functions is not needed.
./drivers/scsi/lpfc/lpfc_mem.c:255:2-18: WARNING: NULL check before some
freeing functions is not needed.
./drivers/scsi/lpfc/lpfc_mem.c:258:2-18: WARNING: NULL check before some
freeing functions is not needed.
./drivers/scsi/lpfc/lpfc_mem.c:261:2-18: WARNING: NULL check before some
freeing functions is not needed.
./drivers/scsi/lpfc/lpfc_mem.c:265:2-18: WARNING: NULL check before some
freeing functions is not needed.
./drivers/scsi/lpfc/lpfc_mem.c:269:2-17: WARNING: NULL check before some
freeing functions is not needed.

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent d508e31d

drivers/scsi/lpfc/lpfc_mem.c

+9 −12

Original line number	Diff line number	Diff line
		@@ -248,24 +248,21 @@ lpfc_mem_free(struct lpfc_hba *phba)

		/* Free HBQ pools */
		lpfc_sli_hbqbuf_free_all(phba);
		if (phba->lpfc_nvmet_drb_pool)
		dma_pool_destroy(phba->lpfc_nvmet_drb_pool);
		phba->lpfc_nvmet_drb_pool = NULL;
		if (phba->lpfc_drb_pool)

		dma_pool_destroy(phba->lpfc_drb_pool);
		phba->lpfc_drb_pool = NULL;
		if (phba->lpfc_hrb_pool)

		dma_pool_destroy(phba->lpfc_hrb_pool);
		phba->lpfc_hrb_pool = NULL;
		if (phba->txrdy_payload_pool)

		dma_pool_destroy(phba->txrdy_payload_pool);
		phba->txrdy_payload_pool = NULL;

		if (phba->lpfc_hbq_pool)
		dma_pool_destroy(phba->lpfc_hbq_pool);
		phba->lpfc_hbq_pool = NULL;

		if (phba->rrq_pool)
		mempool_destroy(phba->rrq_pool);
		phba->rrq_pool = NULL;

Admin message