Commit a954380a authored Oct 08, 2019 by Vinicius Costa Gomes Committed by Jakub Kicinski Oct 09, 2019

net: taprio: Fix returning EINVAL when configuring without flags



When configuring a taprio instance if "flags" is not specified (or
it's zero), taprio currently replies with an "Invalid argument" error.

So, set the return value to zero after we are done with all the
checks.

Fixes: 9c66d156 ("taprio: Add support for hardware offloading")
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Acked-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>

parent 8cd6f4fe

net/sched/sch_taprio.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1341,6 +1341,10 @@ static int taprio_parse_clockid(struct Qdisc sch, struct nlattr *tb,
		NL_SET_ERR_MSG(extack, "Specifying a 'clockid' is mandatory");
		goto out;
		}

		/* Everything went ok, return success. */
		err = 0;

		out:
		return err;
		}

Admin message