Commit a946e8c7 authored by Sudeep Holla's avatar Sudeep Holla Committed by Thomas Gleixner
Browse files

genirq: Delay incrementing interrupt count if it's disabled/pending 



In case of a wakeup interrupt, irq_pm_check_wakeup disables the interrupt
and marks it pending and suspended, disables it and notifies the pm core
about the wake event. The interrupt gets handled later once the system
is resumed.

However the irq stats is updated twice: once when it's disabled waiting
for the system to resume and later when it's handled, resulting in wrong
counting of the wakeup interrupt when waking up the system.

This patch updates the interrupt count so that it's updated only when
the interrupt gets handled. It's already handled correctly in
handle_edge_irq and handle_edge_eoi_irq.

Reported-by: default avatarManoil Claudiu <claudiu.manoil@freescale.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link: http://lkml.kernel.org/r/1446661957-1019-1-git-send-email-sudeep.holla@arm.com


Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 8005c49d

kernel/irq/chip.c

+4 −4
Original line number Diff line number Diff line
@@ -338,7 +338,6 @@ void handle_nested_irq(unsigned int irq) 
	raw_spin_lock_irq(&desc->lock);



	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);

	kstat_incr_irqs_this_cpu(desc);



	action = desc->action;

	if (unlikely(!action || irqd_irq_disabled(&desc->irq_data))) {
@@ -346,6 +345,7 @@ void handle_nested_irq(unsigned int irq) 
		goto out_unlock;

	}



	kstat_incr_irqs_this_cpu(desc);

	irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);

	raw_spin_unlock_irq(&desc->lock);
@@ -412,13 +412,13 @@ void handle_simple_irq(struct irq_desc *desc) 
		goto out_unlock;



	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);

	kstat_incr_irqs_this_cpu(desc);



	if (unlikely(!desc->action || irqd_irq_disabled(&desc->irq_data))) {

		desc->istate |= IRQS_PENDING;

		goto out_unlock;

	}



	kstat_incr_irqs_this_cpu(desc);

	handle_irq_event(desc);



out_unlock:
@@ -462,7 +462,6 @@ void handle_level_irq(struct irq_desc *desc) 
		goto out_unlock;



	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);

	kstat_incr_irqs_this_cpu(desc);



	/*

	 * If its disabled or no action available
@@ -473,6 +472,7 @@ void handle_level_irq(struct irq_desc *desc) 
		goto out_unlock;

	}



	kstat_incr_irqs_this_cpu(desc);

	handle_irq_event(desc);



	cond_unmask_irq(desc);
@@ -532,7 +532,6 @@ void handle_fasteoi_irq(struct irq_desc *desc) 
		goto out;



	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);

	kstat_incr_irqs_this_cpu(desc);



	/*

	 * If its disabled or no action available
@@ -544,6 +543,7 @@ void handle_fasteoi_irq(struct irq_desc *desc) 
		goto out;

	}



	kstat_incr_irqs_this_cpu(desc);

	if (desc->istate & IRQS_ONESHOT)

		mask_irq(desc);

CRA Git | Maintained and supported by SUSTech CRA and CCSE