Commit a93b3331 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: fix async close() with f_op->flush() 



First, io_close() misses filp_close() and io_cqring_add_event(), when
f_op->flush is defined. That's because in this case it will
io_queue_async_work() itself not grabbing files, so the corresponding
chunk in io_close_finish() won't be executed.

Second, when submitted through io_wq_submit_work(), it will do
filp_close() and *_add_event() twice: first inline in io_close(),
and the second one in call to io_close_finish() from io_close().
The second one will also fire, because it was submitted async through
generic path, and so have grabbed files.

And the last nice thing is to remove this weird pilgrimage with checking
work/old_work and casting it to nxt. Just use a helper instead.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 0b5faf6b

fs/io_uring.c

+16 −29
Original line number Diff line number Diff line
@@ -2870,24 +2870,25 @@ static int io_close_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) 
	return 0;

}



static void io_close_finish(struct io_wq_work **workptr)

/* only called when __close_fd_get_file() is done */

static void __io_close_finish(struct io_kiocb *req, struct io_kiocb **nxt)

{

	struct io_kiocb *req = container_of(*workptr, struct io_kiocb, work);

	struct io_kiocb *nxt = NULL;



	/* Invoked with files, we need to do the close */

	if (req->work.files) {

	int ret;



	ret = filp_close(req->close.put_file, req->work.files);

	if (ret < 0)

		req_set_fail_links(req);

	io_cqring_add_event(req, ret);

	fput(req->close.put_file);

	io_put_req_find_next(req, nxt);

}



	fput(req->close.put_file);

static void io_close_finish(struct io_wq_work **workptr)

{

	struct io_kiocb *req = container_of(*workptr, struct io_kiocb, work);

	struct io_kiocb *nxt = NULL;



	io_put_req_find_next(req, &nxt);

	__io_close_finish(req, &nxt);

	if (nxt)

		io_wq_assign_next(workptr, nxt);

}
@@ -2910,22 +2911,8 @@ static int io_close(struct io_kiocb *req, struct io_kiocb **nxt, 
	 * No ->flush(), safely close from here and just punt the

	 * fput() to async context.

	 */

	ret = filp_close(req->close.put_file, current->files);



	if (ret < 0)

		req_set_fail_links(req);

	io_cqring_add_event(req, ret);



	if (io_wq_current_is_worker()) {

		struct io_wq_work *old_work, *work;



		old_work = work = &req->work;

		io_close_finish(&work);

		if (work && work != old_work)

			*nxt = container_of(work, struct io_kiocb, work);

	__io_close_finish(req, nxt);

	return 0;

	}



eagain:

	req->work.func = io_close_finish;

	/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE