mtd: rawnand: ndfc: Stop using nand_release() (a9384f95) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-32-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/ndfc.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -244,9 +244,13 @@ static int ndfc_probe(struct platform_device *ofdev)
		static int ndfc_remove(struct platform_device *ofdev)
		{
		struct ndfc_controller *ndfc = dev_get_drvdata(&ofdev->dev);
		struct mtd_info *mtd = nand_to_mtd(&ndfc->chip);
		struct nand_chip *chip = &ndfc->chip;
		struct mtd_info *mtd = nand_to_mtd(chip);
		int ret;

		nand_release(&ndfc->chip);
		ret = mtd_device_unregister(mtd);
		WARN_ON(ret);
		nand_cleanup(chip);
		kfree(mtd->name);

		return 0;

Admin message