Commit a92fe7b3 authored by Arjan van de Ven's avatar Arjan van de Ven Committed by Ingo Molnar
Browse files

perf timechart: Show the duration of scheduler delays in the SVG 



Given that scheduler latencies are the hot thing nowadays, show the
duration of said latencies in the SVG in text form.

In addition, if the latency is more than 10 msec, pick a brighter
yellow color as a way to point these long delays out.

Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <20090920181353.796f4509@linux.intel.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 4f1202c8

tools/perf/builtin-timechart.c

+3 −3
Original line number Diff line number Diff line
@@ -827,15 +827,15 @@ static void draw_process_bars(void) 
				continue;

			}



			svg_box(Y, p->start_time, p->end_time, "process");

			svg_box(Y, c->start_time, c->end_time, "process");

			sample = c->samples;

			while (sample) {

				if (sample->type == TYPE_RUNNING)

					svg_sample(Y, sample->cpu, sample->start_time, sample->end_time, "sample");

					svg_sample(Y, sample->cpu, sample->start_time, sample->end_time);

				if (sample->type == TYPE_BLOCKED)

					svg_box(Y, sample->start_time, sample->end_time, "blocked");

				if (sample->type == TYPE_WAITING)

					svg_box(Y, sample->start_time, sample->end_time, "waiting");

					svg_waiting(Y, sample->start_time, sample->end_time);

				sample = sample->next;

			}

tools/perf/util/svghelper.c

+52 −4
Original line number Diff line number Diff line
@@ -69,7 +69,8 @@ void open_svg(const char *filename, int cpus, int rows) 
	fprintf(svgfile, "      rect.process2 { fill:rgb(180,180,180); fill-opacity:0.9; stroke-width:0;   stroke:rgb(  0,  0,  0); } \n");

	fprintf(svgfile, "      rect.sample   { fill:rgb(  0,  0,255); fill-opacity:0.8; stroke-width:0;   stroke:rgb(  0,  0,  0); } \n");

	fprintf(svgfile, "      rect.blocked  { fill:rgb(255,  0,  0); fill-opacity:0.5; stroke-width:0;   stroke:rgb(  0,  0,  0); } \n");

	fprintf(svgfile, "      rect.waiting  { fill:rgb(255,255,  0); fill-opacity:0.3; stroke-width:0;   stroke:rgb(  0,  0,  0); } \n");

	fprintf(svgfile, "      rect.waiting  { fill:rgb(214,214,  0); fill-opacity:0.3; stroke-width:0;   stroke:rgb(  0,  0,  0); } \n");

	fprintf(svgfile, "      rect.WAITING  { fill:rgb(255,214, 48); fill-opacity:0.6; stroke-width:0;   stroke:rgb(  0,  0,  0); } \n");

	fprintf(svgfile, "      rect.cpu      { fill:rgb(192,192,192); fill-opacity:0.2; stroke-width:0.5; stroke:rgb(128,128,128); } \n");

	fprintf(svgfile, "      rect.pstate   { fill:rgb(128,128,128); fill-opacity:0.8; stroke-width:0; } \n");

	fprintf(svgfile, "      rect.c1       { fill:rgb(255,214,214); fill-opacity:0.5; stroke-width:0; } \n");
@@ -92,14 +93,14 @@ void svg_box(int Yslot, u64 start, u64 end, const char *type) 
		time2pixels(start), time2pixels(end)-time2pixels(start), Yslot * SLOT_MULT, SLOT_HEIGHT, type);

}



void svg_sample(int Yslot, int cpu, u64 start, u64 end, const char *type)

void svg_sample(int Yslot, int cpu, u64 start, u64 end)

{

	double text_size;

	if (!svgfile)

		return;



	fprintf(svgfile, "<rect x=\"%4.8f\" width=\"%4.8f\" y=\"%4.1f\" height=\"%4.1f\" class=\"%s\"/>\n",

		time2pixels(start), time2pixels(end)-time2pixels(start), Yslot * SLOT_MULT, SLOT_HEIGHT, type);

	fprintf(svgfile, "<rect x=\"%4.8f\" width=\"%4.8f\" y=\"%4.1f\" height=\"%4.1f\" class=\"sample\"/>\n",

		time2pixels(start), time2pixels(end)-time2pixels(start), Yslot * SLOT_MULT, SLOT_HEIGHT);



	text_size = (time2pixels(end)-time2pixels(start));

	if (cpu > 9)
@@ -112,6 +113,53 @@ void svg_sample(int Yslot, int cpu, u64 start, u64 end, const char *type) 


}



static char *time_to_string(u64 duration)

{

	static char text[80];



	text[0] = 0;



	if (duration < 1000) /* less than 1 usec */

		return text;



	if (duration < 1000 * 1000) { /* less than 1 msec */

		sprintf(text, "%4.1f us", duration / 1000.0);

		return text;

	}

	sprintf(text, "%4.1f ms", duration / 1000.0 / 1000);



	return text;

}



void svg_waiting(int Yslot, u64 start, u64 end)

{

	char *text;

	const char *style;

	double font_size;



	if (!svgfile)

		return;



	style = "waiting";



	if (end-start > 10 * 1000000) /* 10 msec */

		style = "WAITING";



	text = time_to_string(end-start);



	font_size = 1.0 * (time2pixels(end)-time2pixels(start)) / strlen(text);



	if (font_size > 0.2)

		font_size = 0.2;





	fprintf(svgfile, "<rect x=\"%4.8f\" width=\"%4.8f\" y=\"%4.1f\" height=\"%4.1f\" class=\"%s\"/>\n",

		time2pixels(start), time2pixels(end)-time2pixels(start), Yslot * SLOT_MULT, SLOT_HEIGHT, style);

	if (font_size > MIN_TEXT_SIZE)

		fprintf(svgfile, "<text transform=\"translate(%1.8f,%1.8f)\" font-size=\"%1.6fpt\">%s</text>\n",

			time2pixels(start), Yslot * SLOT_MULT + 2, font_size, text);

}



static char *cpu_model(void)

{

	static char cpu_m[255];

tools/perf/util/svghelper.h

+2 −1
Original line number Diff line number Diff line
@@ -5,7 +5,8 @@ 


extern void open_svg(const char *filename, int cpus, int rows);

extern void svg_box(int Yslot, u64 start, u64 end, const char *type);

extern void svg_sample(int Yslot, int cpu, u64 start, u64 end, const char *type);

extern void svg_sample(int Yslot, int cpu, u64 start, u64 end);

extern void svg_waiting(int Yslot, u64 start, u64 end);

extern void svg_cpu_box(int cpu, u64 max_frequency, u64 turbo_frequency);

CRA Git | Maintained and supported by SUSTech CRA and CCSE