Commit a92e1bb6 authored Feb 28, 2019 by Maciej Fijalkowski Committed by Jeff Kirsher May 02, 2019

ice: Validate ring existence and its q_vector per VSI



When stopping Tx rings, we use 'i' as an ring array index for looking up
whether the ice_ring exists and have assigned a q_vector. This checks
rings only within a given TC and we need to go through every ring in
VSI. Use 'q_idx' instead.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 1553f4f7

drivers/net/ethernet/intel/ice/ice_lib.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2072,7 +2072,8 @@ ice_vsi_stop_tx_rings(struct ice_vsi *vsi, enum ice_disq_rst_src rst_src,
		for (i = 0; i < vsi->tc_cfg.tc_info[tc].qcount_tx; i++) {
		u16 v_idx;

		if (!rings \|\| !rings[i] \|\| !rings[i]->q_vector) {
		if (!rings \|\| !rings[q_idx] \|\|
		!rings[q_idx]->q_vector) {
		err = -EINVAL;
		goto err_out;
		}

Admin message