Commit a92d3ff9 authored by Pavel V. Panteleev's avatar Pavel V. Panteleev Committed by Tejun Heo
Browse files

percpu: fix trivial bugs in pcpu_build_alloc_info() 



Fix the following two trivial bugs in pcpu_build_alloc_info()

* we should memset group_cnt to 0 by size of group_cnt, not size of
  group_map (both are of the same size, so the bug isn't dangerous)

* we can delete useless variable group_cnt_max.

Signed-off-by: default avatarPavel V. Panteleev <pp_84@mail.ru>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 7e27d6e7

mm/percpu.c

+2 −3
Original line number Diff line number Diff line
@@ -1086,7 +1086,7 @@ struct pcpu_alloc_info * __init pcpu_build_alloc_info( 
	static int group_map[NR_CPUS] __initdata;

	static int group_cnt[NR_CPUS] __initdata;

	const size_t static_size = __per_cpu_end - __per_cpu_start;

	int group_cnt_max = 0, nr_groups = 1, nr_units = 0;

	int nr_groups = 1, nr_units = 0;

	size_t size_sum, min_unit_size, alloc_size;

	int upa, max_upa, uninitialized_var(best_upa);	/* units_per_alloc */

	int last_allocs, group, unit;
@@ -1096,7 +1096,7 @@ struct pcpu_alloc_info * __init pcpu_build_alloc_info( 


	/* this function may be called multiple times */

	memset(group_map, 0, sizeof(group_map));

	memset(group_cnt, 0, sizeof(group_map));

	memset(group_cnt, 0, sizeof(group_cnt));



	/*

	 * Determine min_unit_size, alloc_size and max_upa such that
@@ -1130,7 +1130,6 @@ struct pcpu_alloc_info * __init pcpu_build_alloc_info( 
		}

		group_map[cpu] = group;

		group_cnt[group]++;

		group_cnt_max = max(group_cnt_max, group_cnt[group]);

	}



	/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE