drivers: gpio: amd8111: prefer dev_err()/dev_info() over raw printk (a922a244) · Commits · 戴 / test

For logging in device contexts, dev_*() functions are preferred over raw printk(), which also print out device name. Signed-off-by:

drivers/gpio/gpio-amd8111.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -179,7 +179,6 @@ static int __init amd_gpio_init(void)
		struct pci_dev *pdev = NULL;
		const struct pci_device_id *ent;


		/* We look for our device - AMD South Bridge
		* I don't know about a system with two such bridges,
		* so we can assume that there is max. one device.
		@@ -223,11 +222,10 @@ found:

		spin_lock_init(&gp.lock);

		printk(KERN_INFO "AMD-8111 GPIO detected\n");
		dev_info(&pdev->dev, "AMD-8111 GPIO detected\n");
		err = gpiochip_add_data(&gp.chip, &gp);
		if (err) {
		printk(KERN_ERR "GPIO registering failed (%d)\n",
		err);
		dev_err(&pdev->dev, "GPIO registering failed (%d)\n", err);
		ioport_unmap(gp.pm);
		goto out;
		}