Commit a913e5e8 authored Nov 27, 2018 by Anju T Sudhakar Committed by Michael Ellerman May 03, 2019

powerpc/perf: Return accordingly on invalid chip-id in



Nest hardware counter memory resides in a per-chip reserve-memory.
During nest_imc_event_init(), chip-id of the event-cpu is considered to
calculate the base memory addresss for that cpu. Return, proper error
condition if the chip_id calculated is invalid.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 885dcd70 ("powerpc/perf: Add nest IMC PMU support")
Reviewed-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 659a6e38

arch/powerpc/perf/imc-pmu.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -487,6 +487,11 @@ static int nest_imc_event_init(struct perf_event *event)
		* Get the base memory addresss for this cpu.
		*/
		chip_id = cpu_to_chip_id(event->cpu);

		/* Return, if chip_id is not valid */
		if (chip_id < 0)
		return -ENODEV;

		pcni = pmu->mem_info;
		do {
		if (pcni->id == chip_id) {

Admin message