Commit a90295b4 authored May 09, 2016 by Paul Gortmaker Committed by Linus Walleij May 11, 2016

gpio: zevio: make it explicitly non-modular



The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_ZEVIO
drivers/gpio/Kconfig:   bool "LSI ZEVIO SoC memory mapped GPIOs"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Fabian Vogt <fabian@ritter-vogt.de>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 52ad9053

drivers/gpio/gpio-zevio.c

+3 −18

Original line number	Diff line number	Diff line
		@@ -10,7 +10,7 @@

		#include <linux/spinlock.h>
		#include <linux/errno.h>
		#include <linux/module.h>
		#include <linux/init.h>
		#include <linux/bitops.h>
		#include <linux/io.h>
		#include <linux/of_device.h>
		@@ -203,32 +203,17 @@ static int zevio_gpio_probe(struct platform_device *pdev)
		return 0;
		}

		static int zevio_gpio_remove(struct platform_device *pdev)
		{
		struct zevio_gpio *controller = platform_get_drvdata(pdev);

		of_mm_gpiochip_remove(&controller->chip);

		return 0;
		}

		static const struct of_device_id zevio_gpio_of_match[] = {
		{ .compatible = "lsi,zevio-gpio", },
		{ },
		};

		MODULE_DEVICE_TABLE(of, zevio_gpio_of_match);

		static struct platform_driver zevio_gpio_driver = {
		.driver = {
		.name = "gpio-zevio",
		.of_match_table = zevio_gpio_of_match,
		.suppress_bind_attrs = true,
		},
		.probe = zevio_gpio_probe,
		.remove = zevio_gpio_remove,
		};
		module_platform_driver(zevio_gpio_driver);

		MODULE_LICENSE("GPL");
		MODULE_AUTHOR("Fabian Vogt <fabian@ritter-vogt.de>");
		MODULE_DESCRIPTION("LSI ZEVIO SoC GPIO driver");
		builtin_platform_driver(zevio_gpio_driver);

Admin message