ALSA: dice: use the same size of period for PCM substream in AMDTP streams (a8fb2248) · Commits · 戴 / test

In current implementation, when opening a PCM substream, it's needed to check whether the opposite PCM substream runs. This is to assign effectual constraints (e.g. sampling rate) to opened PCM substream. The number of PCM substreams and MIDI substreams on AMDTP streams in domain is recorded in own structure. Usage of this count is an alternative of the above check. This is better because the count is incremented in pcm.hw_params earlier than pcm.trigger. This idea has one issue because it's incremented for MIDI substreams as well. In current implementation, for a case that any MIDI substream run and a PCM substream is going to start, PCM application to start the PCM substream can decide hardware parameters by restart packet streaming. Just checking the substream count can brings regression. Now AMDTP domain structure has a member for the size of PCM period in PCM substream which starts AMDTP streams in domain. When the value has zero and the substream count is greater than 1, it means that any MIDI substream starts AMDTP streams in domain. Usage of the value can resolve the above issue. This commit replaces the check with the substream count and the value for the size of PCM period. Dice hardware has a quirk called as 'Dual Wire'. For a case of higher sampling transmission frequency, this commit performs calculations between the number of PCM frames and the number of events in AMDTP stream. Signed-off-by:

Takashi Sakamoto <o-takashi@sakamocchi.jp> Link: https://lore.kernel.org/r/20191007110532.30270-14-o-takashi@sakamocchi.jp Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/firewire/dice/dice-pcm.c

+31 −12

Original line number	Diff line number	Diff line
		@@ -164,13 +164,14 @@ static int init_hw_info(struct snd_dice *dice,
		static int pcm_open(struct snd_pcm_substream *substream)
		{
		struct snd_dice *dice = substream->private_data;
		struct amdtp_domain *d = &dice->domain;
		unsigned int source;
		bool internal;
		int err;

		err = snd_dice_stream_lock_try(dice);
		if (err < 0)
		goto end;
		return err;

		err = init_hw_info(dice, substream);
		if (err < 0)
		@@ -195,27 +196,45 @@ static int pcm_open(struct snd_pcm_substream *substream)
		break;
		}

		/*
		* When source of clock is not internal or any PCM streams are running,
		* available sampling rate is limited at current sampling rate.
		*/
		mutex_lock(&dice->mutex);

		// When source of clock is not internal or any stream is reserved for
		// transmission of PCM frames, the available sampling rate is limited
		// at current one.
		if (!internal \|\|
		amdtp_stream_pcm_running(&dice->tx_stream[0]) \|\|
		amdtp_stream_pcm_running(&dice->tx_stream[1]) \|\|
		amdtp_stream_pcm_running(&dice->rx_stream[0]) \|\|
		amdtp_stream_pcm_running(&dice->rx_stream[1])) {
		(dice->substreams_counter > 0 && d->events_per_period > 0)) {
		unsigned int frames_per_period = d->events_per_period;
		unsigned int rate;

		err = snd_dice_transaction_get_rate(dice, &rate);
		if (err < 0)
		if (err < 0) {
		mutex_unlock(&dice->mutex);
		goto err_locked;
		}

		substream->runtime->hw.rate_min = rate;
		substream->runtime->hw.rate_max = rate;

		if (frames_per_period > 0) {
		// For double_pcm_frame quirk.
		if (rate > 96000)
		frames_per_period *= 2;

		err = snd_pcm_hw_constraint_minmax(substream->runtime,
		SNDRV_PCM_HW_PARAM_PERIOD_SIZE,
		frames_per_period, frames_per_period);
		if (err < 0) {
		mutex_unlock(&dice->mutex);
		goto err_locked;
		}
		}
		}

		mutex_unlock(&dice->mutex);

		snd_pcm_set_sync(substream);
		end:
		return err;

		return 0;
		err_locked:
		snd_dice_stream_lock_release(dice);
		return err;

Admin message