Commit a8f50345 authored Jun 28, 2005 by KAMBAROV, ZAUR Committed by Linus Torvalds Jun 28, 2005

[PATCH] coverity: i386: build.c: negative return to unsigned fix



Variable "c" was declared as an unsigned int, but used in:

125  		for (i=0 ; (c=read(fd, buf, sizeof(buf)))>0 ; i+=c )
126  			if (write(1, buf, c) != c)
127  				die("Write call failed");

(akpm: read() can return -1.  If it does, we fill the disk up with garbage).

Signed-off-by: Zaur Kambarov <zkambarov@coverity.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 4cceb4d1

arch/i386/boot/tools/build.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -70,7 +70,8 @@ void usage(void)

		int main(int argc, char ** argv)
		{
		unsigned int i, c, sz, setup_sectors;
		unsigned int i, sz, setup_sectors;
		int c;
		u32 sys_size;
		byte major_root, minor_root;
		struct stat sb;

Admin message