usbcore: Bug fix: system can't suspend with USB3.0 device connected to USB3.0 hub (a8f08d86) · Commits · 戴 / test

This patch clear PORT_POWER when suspend a USB3.0 device behind a USB3.0 external hub, so the system can suspend and resume. Note USB3.0 device may not work after system resume and this is a temporary workaround. The correct fix will be in future patches. Signed-off-by:

Andiry Xu <andiry.xu@amd.com> Signed-off-by:

Sarah Sharp <sarah.a.sharp@linux.intel.com>

drivers/usb/core/hub.c

+11 −1

Original line number	Diff line number	Diff line
		@@ -2285,7 +2285,17 @@ int usb_port_suspend(struct usb_device *udev, pm_message_t msg)
		}

		/* see 7.1.7.6 */
		status = set_port_feature(hub->hdev, port1, USB_PORT_FEAT_SUSPEND);
		/* Clear PORT_POWER if it's a USB3.0 device connected to USB 3.0
		* external hub.
		* FIXME: this is a temporary workaround to make the system able
		* to suspend/resume.
		*/
		if ((hub->hdev->parent != NULL) && hub_is_superspeed(hub->hdev))
		status = clear_port_feature(hub->hdev, port1,
		USB_PORT_FEAT_POWER);
		else
		status = set_port_feature(hub->hdev, port1,
		USB_PORT_FEAT_SUSPEND);
		if (status) {
		dev_dbg(hub->intfdev, "can't suspend port %d, status %d\n",
		port1, status);

Admin message