Commit a8eab6d3 authored Apr 02, 2020 by Cong Wang Committed by David S. Miller Apr 03, 2020

net_sched: fix a missing refcnt in tcindex_init()

The initial refcnt of struct tcindex_data should be 1,
it is clear that I forgot to set it to 1 in tcindex_init().
This leads to a dec-after-zero warning.

Reported-by:  <syzbot+8325e509a1bf83ec741d@syzkaller.appspotmail.com>
Fixes: 304e0242 ("net_sched: add a temporary refcnt for struct tcindex_data")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3e1221ac

net/sched/cls_tcindex.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -151,6 +151,7 @@ static int tcindex_init(struct tcf_proto *tp)
		p->mask = 0xffff;
		p->hash = DEFAULT_HASH_SIZE;
		p->fall_through = 1;
		refcount_set(&p->refcnt, 1); /* Paired with tcindex_destroy_work() */

		rcu_assign_pointer(tp->root, p);
		return 0;

Admin message