Commit a8e63bff authored Sep 22, 2005 by Latchesar Ionkov Committed by Linus Torvalds Sep 22, 2005

[PATCH] v9fs: make copy of the transport prototype instead of using it directly



When a new session is created it uses a template object of the specified
transport type to instantiate its own copy.  The code for the making a copy of
the template object was lost, and the object itself is attached to the v9fs
session.  This leads to many sessions using the same transport instead of
having their own copy.

The patch puts back the code that makes a copy of the template object.

Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 5b067676

fs/9p/v9fs.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -303,7 +303,13 @@ v9fs_session_init(struct v9fs_session_info *v9ses,
		goto SessCleanUp;
		};

		v9ses->transport = trans_proto;
		v9ses->transport = kmalloc(sizeof(*v9ses->transport), GFP_KERNEL);
		if (!v9ses->transport) {
		retval = -ENOMEM;
		goto SessCleanUp;
		}

		memmove(v9ses->transport, trans_proto, sizeof(*v9ses->transport));

		if ((retval = v9ses->transport->init(v9ses, dev_name, data)) < 0) {
		eprintk(KERN_ERR, "problem initializing transport\n");

Admin message