Commit a8db6140 authored Feb 02, 2018 by Arnd Bergmann Committed by Martin K. Petersen Feb 13, 2018

scsi: qedf: use correct strncpy() size

gcc-8 warns during link-time optimization that the strncpy() call passes
the size of the source buffer rather than the destination:

drivers/scsi/qedf/qedf_dbg.c: In function 'qedf_uevent_emit':
include/linux/string.h:253: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]

This changes it to strscpy() with the correct length, guaranteeing a
properly nul-terminated string of the right size.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent d9ea463a

drivers/scsi/qedf/qedf_dbg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -160,7 +160,7 @@ qedf_uevent_emit(struct Scsi_Host shost, u32 code, char msg)
		switch (code) {
		case QEDF_UEVENT_CODE_GRCDUMP:
		if (msg)
		strncpy(event_string, msg, strlen(msg));
		strscpy(event_string, msg, sizeof(event_string));
		else
		sprintf(event_string, "GRCDUMP=%u", shost->host_no);
		break;

Admin message