Commit a8d8d1de authored by Antonio Quartulli's avatar Antonio Quartulli Committed by Simon Wunderlich
Browse files

batman-adv: disable sysfs knobs when GW-mode is not implemented 



Now that the GW-mode code is algorithm specific, batman-adv expects the
routing algorithm to implement some APIs to make it work.

However, such APIs are not mandatory, therefore we might have algorithms
not providing them. In this case all the sysfs knobs related to GW-mode
should be deactivated to make sure that settings injected by the user
for this feature are rejected.

Signed-off-by: default avatarAntonio Quartulli <a@unstable.cc>
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 50164d8f

net/batman-adv/sysfs.c

+28 −0
Original line number Diff line number Diff line
@@ -429,6 +429,13 @@ static ssize_t batadv_show_gw_mode(struct kobject *kobj, struct attribute *attr, 
	struct batadv_priv *bat_priv = batadv_kobj_to_batpriv(kobj);

	int bytes_written;



	/* GW mode is not available if the routing algorithm in use does not

	 * implement the GW API

	 */

	if (!bat_priv->algo_ops->gw.get_best_gw_node ||

	    !bat_priv->algo_ops->gw.is_eligible)

		return -ENOENT;



	switch (atomic_read(&bat_priv->gw.mode)) {

	case BATADV_GW_MODE_CLIENT:

		bytes_written = sprintf(buff, "%s\n",
@@ -456,6 +463,13 @@ static ssize_t batadv_store_gw_mode(struct kobject *kobj, 
	char *curr_gw_mode_str;

	int gw_mode_tmp = -1;



	/* toggling GW mode is allowed only if the routing algorithm in use

	 * provides the GW API

	 */

	if (!bat_priv->algo_ops->gw.get_best_gw_node ||

	    !bat_priv->algo_ops->gw.is_eligible)

		return -EINVAL;



	if (buff[count - 1] == '\n')

		buff[count - 1] = '\0';
@@ -520,6 +534,13 @@ static ssize_t batadv_show_gw_sel_class(struct kobject *kobj, 
{

	struct batadv_priv *bat_priv = batadv_kobj_to_batpriv(kobj);



	/* GW selection class is not available if the routing algorithm in use

	 * does not implement the GW API

	 */

	if (!bat_priv->algo_ops->gw.get_best_gw_node ||

	    !bat_priv->algo_ops->gw.is_eligible)

		return -ENOENT;



	if (bat_priv->algo_ops->gw.show_sel_class)

		return bat_priv->algo_ops->gw.show_sel_class(bat_priv, buff);
@@ -532,6 +553,13 @@ static ssize_t batadv_store_gw_sel_class(struct kobject *kobj, 
{

	struct batadv_priv *bat_priv = batadv_kobj_to_batpriv(kobj);



	/* setting the GW selection class is allowed only if the routing

	 * algorithm in use implements the GW API

	 */

	if (!bat_priv->algo_ops->gw.get_best_gw_node ||

	    !bat_priv->algo_ops->gw.is_eligible)

		return -EINVAL;



	if (buff[count - 1] == '\n')

		buff[count - 1] = '\0';

CRA Git | Maintained and supported by SUSTech CRA and CCSE