Commit a8d63a53 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by David S. Miller
Browse files

rds: remove unnecessary returned value check 



The function rds_trans_register always returns 0. As such, it is not
necessary to check the returned value.

Cc: Joe Jin <joe.jin@oracle.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 37411cad

net/rds/ib.c

+1 −5
Original line number Diff line number Diff line
@@ -438,16 +438,12 @@ int rds_ib_init(void) 
	if (ret)

		goto out_sysctl;



	ret = rds_trans_register(&rds_ib_transport);

	if (ret)

		goto out_recv;

	rds_trans_register(&rds_ib_transport);



	rds_info_register_func(RDS_INFO_IB_CONNECTIONS, rds_ib_ic_info);



	goto out;



out_recv:

	rds_ib_recv_exit();

out_sysctl:

	rds_ib_sysctl_exit();

out_ibreg:

net/rds/rds.h

+1 −1
Original line number Diff line number Diff line
@@ -910,7 +910,7 @@ void rds_connect_path_complete(struct rds_conn_path *conn, int curr); 
void rds_connect_complete(struct rds_connection *conn);



/* transport.c */

int rds_trans_register(struct rds_transport *trans);

void rds_trans_register(struct rds_transport *trans);

void rds_trans_unregister(struct rds_transport *trans);

struct rds_transport *rds_trans_get_preferred(struct net *net, __be32 addr);

void rds_trans_put(struct rds_transport *trans);

net/rds/tcp.c

+1 −5
Original line number Diff line number Diff line
@@ -652,16 +652,12 @@ static int rds_tcp_init(void) 
	if (ret)

		goto out_pernet;



	ret = rds_trans_register(&rds_tcp_transport);

	if (ret)

		goto out_recv;

	rds_trans_register(&rds_tcp_transport);



	rds_info_register_func(RDS_INFO_TCP_SOCKETS, rds_tcp_tc_info);



	goto out;



out_recv:

	rds_tcp_recv_exit();

out_pernet:

	unregister_pernet_subsys(&rds_tcp_net_ops);

out_notifier:

net/rds/transport.c

+1 −3
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ 
static struct rds_transport *transports[RDS_TRANS_COUNT];

static DECLARE_RWSEM(rds_trans_sem);



int rds_trans_register(struct rds_transport *trans)

void rds_trans_register(struct rds_transport *trans)

{

	BUG_ON(strlen(trans->t_name) + 1 > TRANSNAMSIZ);
@@ -55,8 +55,6 @@ int rds_trans_register(struct rds_transport *trans) 
	}



	up_write(&rds_trans_sem);



	return 0;

}

EXPORT_SYMBOL_GPL(rds_trans_register);

CRA Git | Maintained and supported by SUSTech CRA and CCSE