Commit a8cc3128 authored by Nicolas Toromanoff's avatar Nicolas Toromanoff Committed by Herbert Xu
Browse files

crypto: stm32/crc32 - fix run-time self test issue. 



Fix wrong crc32 initialisation value:
"alg: shash: stm32_crc32 test failed (wrong result) on test vector 0,
cfg="init+update+final aligned buffer"
cra_name="crc32c" expects an init value of 0XFFFFFFFF,
cra_name="crc32" expects an init value of 0.

Fixes: b51dbe90 ("crypto: stm32 - Support for STM32 CRC32 crypto module")

Signed-off-by: default avatarNicolas Toromanoff <nicolas.toromanoff@st.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 49c2c082

drivers/crypto/stm32/stm32-crc32.c

+3 −3
Original line number Diff line number Diff line
@@ -28,10 +28,10 @@ 


/* Registers values */

#define CRC_CR_RESET            BIT(0)

#define CRC_INIT_DEFAULT        0xFFFFFFFF

#define CRC_CR_REV_IN_WORD      (BIT(6) | BIT(5))

#define CRC_CR_REV_IN_BYTE      BIT(5)

#define CRC_CR_REV_OUT          BIT(7)

#define CRC32C_INIT_DEFAULT     0xFFFFFFFF



#define CRC_AUTOSUSPEND_DELAY	50
@@ -65,7 +65,7 @@ static int stm32_crc32_cra_init(struct crypto_tfm *tfm) 
{

	struct stm32_crc_ctx *mctx = crypto_tfm_ctx(tfm);



	mctx->key = CRC_INIT_DEFAULT;

	mctx->key = 0;

	mctx->poly = CRC32_POLY_LE;

	return 0;

}
@@ -74,7 +74,7 @@ static int stm32_crc32c_cra_init(struct crypto_tfm *tfm) 
{

	struct stm32_crc_ctx *mctx = crypto_tfm_ctx(tfm);



	mctx->key = CRC_INIT_DEFAULT;

	mctx->key = CRC32C_INIT_DEFAULT;

	mctx->poly = CRC32C_POLY_LE;

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE