Commit a8c8af59 authored Aug 20, 2019 by Xu YiPing Committed by Sam Ravnborg Aug 21, 2019

drm: kirin: Fix dev->driver_data setting



As part of refactoring the kirin driver to better support
different hardware revisions, this patch changes the
dev->driver_data to point to a drm_device, not ade_data.

Thus we set the driver data to drm device after alloc.

Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Xu YiPing <xuyiping@hisilicon.com>
[jstultz: Reworded commit message]
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190820230626.23253-22-john.stultz@linaro.org

parent a51735be

drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -999,7 +999,6 @@ static int ade_drm_init(struct platform_device *pdev)
		DRM_ERROR("failed to alloc ade_data\n");
		return -ENOMEM;
		}
		platform_set_drvdata(pdev, ade);

		ctx = ade_hw_ctx_alloc(pdev, &ade->crtc.base);
		if (IS_ERR(ctx)) {

drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -44,8 +44,6 @@ static int kirin_drm_kms_init(struct drm_device *dev)
		{
		int ret;

		dev_set_drvdata(dev->dev, dev);

		/* dev->mode_config initialization */
		drm_mode_config_init(dev);
		dev->mode_config.min_width = 0;
		@@ -140,6 +138,7 @@ static int kirin_drm_bind(struct device *dev)
		drm_dev = drm_dev_alloc(driver_data->driver, dev);
		if (IS_ERR(drm_dev))
		return PTR_ERR(drm_dev);
		dev_set_drvdata(dev, drm_dev);

		ret = kirin_drm_kms_init(drm_dev);
		if (ret)

Admin message