Commit a8b9e0ce authored May 15, 2018 by Amir Goldstein Committed by Miklos Szeredi May 31, 2018

ovl: remove WARN_ON() real inode attributes mismatch



Overlayfs should cope with online changes to underlying layer
without crashing the kernel, which is what xfstest overlay/019
checks.

This test may sometimes trigger WARN_ON() in ovl_create_or_link()
when linking an overlay inode that has been changed on underlying
layer.

Remove those WARN_ON() to prevent the stress test from failing.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

parent 4280f74a

fs/overlayfs/dir.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -510,13 +510,6 @@ static int ovl_create_or_link(struct dentry dentry, struct inode inode,
		}
		out_revert_creds:
		revert_creds(old_cred);
		if (!err) {
		struct inode *realinode = d_inode(ovl_dentry_upper(dentry));

		WARN_ON(inode->i_mode != realinode->i_mode);
		WARN_ON(!uid_eq(inode->i_uid, realinode->i_uid));
		WARN_ON(!gid_eq(inode->i_gid, realinode->i_gid));
		}
		return err;
		}

Admin message