Commit a89e8283 authored Feb 01, 2011 by Ajit Khaparde Committed by David S. Miller Feb 01, 2011

be2net: fix a crash seen during insmod/rmmod test



While running insmod/rmood in a loop, an unnecessary netif_stop_queue
causes the system to crash. Remove the netif_stop_queue call
and netif_start_queue in the link status update path.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a29ae23f

drivers/net/benet/be_main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -312,11 +312,9 @@ void be_link_status_update(struct be_adapter *adapter, bool link_up)
		if (adapter->link_up != link_up) {
		adapter->link_speed = -1;
		if (link_up) {
		netif_start_queue(netdev);
		netif_carrier_on(netdev);
		printk(KERN_INFO "%s: Link up\n", netdev->name);
		} else {
		netif_stop_queue(netdev);
		netif_carrier_off(netdev);
		printk(KERN_INFO "%s: Link down\n", netdev->name);
		}

Admin message