Commit a886ca6f authored Dec 17, 2019 by Aditya Pakki Committed by David S. Miller Dec 19, 2019

hdlcdrv: replace unnecessary assertion in hdlcdrv_register



In hdlcdrv_register, failure to register the driver causes a crash.
The three callers of hdlcdrv_register all pass valid pointers and
do not fail. The patch eliminates the unnecessary BUG_ON assertion.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6791c102

drivers/net/hamradio/hdlcdrv.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -687,8 +687,6 @@ struct net_device hdlcdrv_register(const struct hdlcdrv_ops ops,
		struct hdlcdrv_state *s;
		int err;

		BUG_ON(ops == NULL);

		if (privsize < sizeof(struct hdlcdrv_state))
		privsize = sizeof(struct hdlcdrv_state);

Admin message