Commit a87eeb90 authored Aug 12, 2016 by Tyrel Datwyler Committed by Martin K. Petersen Aug 16, 2016

scsi: fix upper bounds check of sense key in scsi_sense_key_string()



Commit 655ee63c ("scsi constants: command, sense key + additional
sense string") added a "Completed" sense string with key 0xF to
snstext[], but failed to updated the upper bounds check of the sense key
in scsi_sense_key_string().

Fixes: 655ee63c ("[SCSI] scsi constants: command, sense key + additional sense strings")
Cc: <stable@vger.kernel.org> # v3.12+
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent e120dcb6

drivers/scsi/constants.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -361,8 +361,9 @@ static const char * const snstext[] = {

		/* Get sense key string or NULL if not available */
		const char *
		scsi_sense_key_string(unsigned char key) {
		if (key <= 0xE)
		scsi_sense_key_string(unsigned char key)
		{
		if (key < ARRAY_SIZE(snstext))
		return snstext[key];
		return NULL;
		}

Admin message