Commit a8714595 authored Feb 11, 2019 by Colin Ian King Committed by Jason Gunthorpe Feb 11, 2019

RDMA/bnxt_re: fix or'ing of data into an uninitialized struct member



The struct member comp_mask has not been initialized however a bit
pattern is being bitwise or'd into the member and hence other bit
fields in comp_mask may contain any garbage from the stack. Fix this
by making the bitwise or into an assignment.

Fixes: 95b86d1c ("RDMA/bnxt_re: Update kernel user abi to pass chip context")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Devesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent fc9e4477

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3702,7 +3702,7 @@ struct ib_ucontext bnxt_re_alloc_ucontext(struct ib_device ibdev,
		}
		spin_lock_init(&uctx->sh_lock);

		resp.comp_mask \|= BNXT_RE_UCNTX_CMASK_HAVE_CCTX;
		resp.comp_mask = BNXT_RE_UCNTX_CMASK_HAVE_CCTX;
		chip_met_rev_num = rdev->chip_ctx.chip_num;
		chip_met_rev_num \|= ((u32)rdev->chip_ctx.chip_rev & 0xFF) <<
		BNXT_RE_CHIP_ID0_CHIP_REV_SFT;

Admin message