Commit a86db226 authored by Eli Cohen's avatar Eli Cohen Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix error flow cleanup in mlx5e_tc_tun_create_header_ipv4/6 



Be sure to release the neighbour in case of failures after successful
route lookup.

Fixes: 101f4de9 ("net/mlx5e: Move TC tunnel offloading code to separate source file")
Signed-off-by: default avatarEli Cohen <eli@mellanox.com>
Reviewed-by: default avatarRoi Dayan <roid@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 6e4ff1c9

drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c

+12 −6
Original line number Diff line number Diff line
@@ -239,12 +239,15 @@ int mlx5e_tc_tun_create_header_ipv4(struct mlx5e_priv *priv, 
	if (max_encap_size < ipv4_encap_size) {

		mlx5_core_warn(priv->mdev, "encap size %d too big, max supported is %d\n",

			       ipv4_encap_size, max_encap_size);

		return -EOPNOTSUPP;

		err = -EOPNOTSUPP;

		goto out;

	}



	encap_header = kzalloc(ipv4_encap_size, GFP_KERNEL);

	if (!encap_header)

		return -ENOMEM;

	if (!encap_header) {

		err = -ENOMEM;

		goto out;

	}



	/* used by mlx5e_detach_encap to lookup a neigh hash table

	 * entry in the neigh hash table when a user deletes a rule
@@ -355,12 +358,15 @@ int mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv, 
	if (max_encap_size < ipv6_encap_size) {

		mlx5_core_warn(priv->mdev, "encap size %d too big, max supported is %d\n",

			       ipv6_encap_size, max_encap_size);

		return -EOPNOTSUPP;

		err = -EOPNOTSUPP;

		goto out;

	}



	encap_header = kzalloc(ipv6_encap_size, GFP_KERNEL);

	if (!encap_header)

		return -ENOMEM;

	if (!encap_header) {

		err = -ENOMEM;

		goto out;

	}



	/* used by mlx5e_detach_encap to lookup a neigh hash table

	 * entry in the neigh hash table when a user deletes a rule

CRA Git | Maintained and supported by SUSTech CRA and CCSE