Commit a86028f8 authored Dec 18, 2018 by Colin Ian King Committed by Greg Kroah-Hartman Dec 19, 2018

staging: most: sound: replace snprintf with strscpy



Using snprintf without a format specifier is potentially risky if
the string device_name contains format specifiers. Replace this with
the safer and more efficient strscpy.

Cleans up clang warning:
drivers/staging/most/sound/sound.c:673:41: warning: format string is not
a string literal (potentially insecure) [-Wformat-security]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d464b7db

drivers/staging/most/sound/sound.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -670,7 +670,7 @@ skip_adpt_alloc:
		goto err_free_adpt;

		pcm->private_data = channel;
		snprintf(pcm->name, sizeof(pcm->name), device_name);
		strscpy(pcm->name, device_name, sizeof(pcm->name));
		snd_pcm_set_ops(pcm, direction, &pcm_ops);

		if (create) {

Admin message