Commit a841b64d authored Jan 04, 2016 by Markus Elfring Committed by Dave Chinner Jan 04, 2016

XFS: Use a signed return type for suffix_kstrtoint()



The return type "unsigned long" was used by the suffix_kstrtoint()
function even though it will eventually return a negative error code.
Improve this implementation detail by using the type "int" instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent c5ab131b

fs/xfs/xfs_super.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -137,7 +137,7 @@ static const match_table_t tokens = {
	};		};


	STATIC unsigned long		STATIC int
	suffix_kstrtoint(char s, unsigned int base, int res)		suffix_kstrtoint(char s, unsigned int base, int res)
	{		{
	int last, shift_left_factor = 0, _res;		int last, shift_left_factor = 0, _res;

Admin message