Commit a83034f5 authored Mar 23, 2015 by Dan Carpenter Committed by Herbert Xu Mar 23, 2015

crypto: img-hash - shift wrapping bug in img_hash_hw_init()



"hdev->req->nbytes" is an unsigned int so we so we lose the upper 3 bits
to the shift wrap bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 900831a4

drivers/crypto/img-hash.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -464,7 +464,7 @@ static int img_hash_hw_init(struct img_hash_dev *hdev)
		img_hash_write(hdev, CR_RESET, CR_RESET_UNSET);
		img_hash_write(hdev, CR_INTENAB, CR_INT_NEW_RESULTS_SET);

		nbits = (hdev->req->nbytes << 3);
		nbits = (u64)hdev->req->nbytes << 3;
		u = nbits >> 32;
		l = nbits;
		img_hash_write(hdev, CR_MESSAGE_LENGTH_H, u);

Admin message