Commit a82bfd04 authored Sep 08, 2017 by Jiri Olsa Committed by Arnaldo Carvalho de Melo Sep 12, 2017

perf ui progress: Fix progress update



We currently update the 'next' variable only with a single step value.
But it's possible the 'adv' update is bigger than single 'step' value.
This would leave 'next' value under counted and force unnecessary
ui_progress__ops->update calls.

Calculate the amount of steps we need for 'adv' update and increase the
'next' with that amounts of steps.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20170908120510.22515-3-jolsa@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 4d286c89

tools/perf/ui/progress.c

+6 −1

Original line number	Diff line number	Diff line
		#include <linux/kernel.h>
		#include "../cache.h"
		#include "progress.h"

		@@ -14,10 +15,14 @@ struct ui_progress_ops *ui_progress__ops = &null_progress__ops;

		void ui_progress__update(struct ui_progress *p, u64 adv)
		{
		u64 last = p->curr;

		p->curr += adv;

		if (p->curr >= p->next) {
		p->next += p->step;
		u64 nr = DIV_ROUND_UP(p->curr - last, p->step);

		p->next += nr * p->step;
		ui_progress__ops->update(p);
		}
		}

Admin message