Commit a81070ba authored Oct 19, 2013 by Johan Hedberg Committed by Marcel Holtmann Oct 20, 2013

Bluetooth: Fix updating settings when there are no HCI commands to send

It is possible that the Set Connectable management command doesn't cause
any HCI commands to send (such as when BR/EDR is disabled). We can't
just send a response to user space in this case but must also update the
necessary device flags and settings. This patch fixes the issue by using
the recently introduced set_connectable_update_settings function.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent e8ba3a1f

net/bluetooth/mgmt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1483,8 +1483,8 @@ static int set_connectable(struct sock sk, struct hci_dev hdev, void *data,
		if (err < 0) {
		mgmt_pending_remove(cmd);
		if (err == -ENODATA)
		err = send_settings_rsp(sk, MGMT_OP_SET_CONNECTABLE,
		hdev);
		err = set_connectable_update_settings(hdev, sk,
		cp->val);
		goto failed;
		}

Admin message